Skip to content

Add OpenSearch mixin as subfolder #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2025

Conversation

ritvibhatt
Copy link
Collaborator

Description

This PR adds the OpenSearch mixin into the prometheus exporter plugin repository as a subfolder under mixin/. This change improves maintainability and helps the mixin stays in sync with the plugin's metrics.
For every new release of the plugin, the mixin should be updated as well with any new metrics to keep the Grafana dashboards and Prometheus rules/alerts up to date.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]
#346

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ritvi Bhatt <[email protected]>
Signed-off-by: Ritvi Bhatt <[email protected]>
@ritvibhatt ritvibhatt marked this pull request as ready for review July 26, 2025 00:02
@ps48
Copy link
Member

ps48 commented Jul 26, 2025

Thanks for the PR @ritvibhatt this makes sense to keep the mixin folder as part of the releases. This way we don't need to have a version compatibility matrix between the mixin components and the plugin itself. With updates in code we expect the dashboards to be updated.

@ps48 ps48 merged commit 870914b into opensearch-project:main Jul 26, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants