Skip to content

Bug: Repo maintenance #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Feb 26, 2025
Merged

Conversation

Rajrahane
Copy link
Member

Description

Location of the run-tests.yml folder

Issues Resolved

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@navneet1v
Copy link
Collaborator

@Rajrahane the CIs are failing

Signed-off-by: Rajvaibhav Rahane <[email protected]>
Signed-off-by: Rajvaibhav Rahane <[email protected]>
Signed-off-by: Rajvaibhav Rahane <[email protected]>
Signed-off-by: Rajvaibhav Rahane <[email protected]>
@jed326
Copy link
Collaborator

jed326 commented Feb 25, 2025

This is more of a preference but you may want to squash your commits too so that we have readable/meaningful commit messages. We already have 3 commits titled "Repo maintenance", and if you auto squash this PR that will make 4 -- https://github.com/opensearch-project/remote-vector-index-builder/commits/main/

@Rajrahane
Copy link
Member Author

Fixed the CIs
Folder naming was incorrect
And was hoping github had folders in the workflows but No : https://github.com/orgs/community/discussions/15935

@Rajrahane Rajrahane added the bug Something isn't working label Feb 25, 2025
@rchitale7
Copy link
Member

Can we have a top-level setup.cfg file that provides the configuration for black, mypy, and flake8? Something like this: https://github.com/opensearch-project/opensearch-py/blob/main/setup.cfg. pyproject.toml seems fine too. It will help with local development.

Signed-off-by: Rajvaibhav Rahane <[email protected]>
@Rajrahane
Copy link
Member Author

Changed the file to setup.cfg with some black test config as well

Keeping the file with minimal config for now

@Rajrahane Rajrahane requested a review from jed326 February 25, 2025 23:39
Copy link
Member

@rchitale7 rchitale7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change!

Signed-off-by: Rajvaibhav Rahane <[email protected]>
Signed-off-by: Rajvaibhav Rahane <[email protected]>
Signed-off-by: Rajvaibhav Rahane <[email protected]>
Signed-off-by: Rajvaibhav Rahane <[email protected]>
Signed-off-by: Rajvaibhav Rahane <[email protected]>
Signed-off-by: Rajvaibhav Rahane <[email protected]>
* Add Initial Repo Maintenance Files.

Signed-off-by: Rajvaibhav Rahane <[email protected]>

* add github templates, workflows, codeowners

Signed-off-by: Rajvaibhav Rahane <[email protected]>

* Add RELEASING.md and .codecov.yml

Signed-off-by: Rajvaibhav Rahane <[email protected]>

* Add Test CI

Signed-off-by: Rajvaibhav Rahane <[email protected]>

* fix: add pytest to test requirements

Signed-off-by: Rajvaibhav Rahane <[email protected]>

---------

Signed-off-by: Rajvaibhav Rahane <[email protected]>
Signed-off-by: Rajvaibhav Rahane <[email protected]>
@Rajrahane Rajrahane merged commit 065a7ea into opensearch-project:main Feb 26, 2025
4 checks passed
@Rajrahane Rajrahane deleted the repo-maintenance branch February 26, 2025 00:36
rchitale7 pushed a commit to rchitale7/remote-vector-index-builder that referenced this pull request Feb 27, 2025
* Add Initial Repo Maintenance Files.

Signed-off-by: Rajvaibhav Rahane <[email protected]>

* add github templates, workflows, codeowners

Signed-off-by: Rajvaibhav Rahane <[email protected]>

* Add RELEASING.md and .codecov.yml

Signed-off-by: Rajvaibhav Rahane <[email protected]>

* Add Test CI

Signed-off-by: Rajvaibhav Rahane <[email protected]>

* fix: add pytest to test requirements

Signed-off-by: Rajvaibhav Rahane <[email protected]>

* bug: move run-tests.yml to base workflows folder

Signed-off-by: Rajvaibhav Rahane <[email protected]>

* nit: resolve lint errors

Signed-off-by: Rajvaibhav Rahane <[email protected]>

* nit: resolve mypy errors

Signed-off-by: Rajvaibhav Rahane <[email protected]>

* nit: resolve rename errors in run-tests.py

Signed-off-by: Rajvaibhav Rahane <[email protected]>

* add test placeholder

Signed-off-by: Rajvaibhav Rahane <[email protected]>

* add test placeholder

Signed-off-by: Rajvaibhav Rahane <[email protected]>

* Change test config to setup.cfg

Signed-off-by: Rajvaibhav Rahane <[email protected]>

* nit: delete renamed folders, fix placeholder test

Signed-off-by: Rajvaibhav Rahane <[email protected]>

* Add Test CI

Signed-off-by: Rajvaibhav Rahane <[email protected]>

* fix: add pytest to test requirements

Signed-off-by: Rajvaibhav Rahane <[email protected]>

* bug: move run-tests.yml to base workflows folder

Signed-off-by: Rajvaibhav Rahane <[email protected]>

* nit: resolve lint errors

Signed-off-by: Rajvaibhav Rahane <[email protected]>

* nit: resolve mypy errors

Signed-off-by: Rajvaibhav Rahane <[email protected]>

* nit: resolve rename errors in run-tests.py

Signed-off-by: Rajvaibhav Rahane <[email protected]>

* add test placeholder

Signed-off-by: Rajvaibhav Rahane <[email protected]>

* add test placeholder

Signed-off-by: Rajvaibhav Rahane <[email protected]>

* Repo maintenance (opensearch-project#10)

* Add Initial Repo Maintenance Files.

Signed-off-by: Rajvaibhav Rahane <[email protected]>

* add github templates, workflows, codeowners

Signed-off-by: Rajvaibhav Rahane <[email protected]>

* Add RELEASING.md and .codecov.yml

Signed-off-by: Rajvaibhav Rahane <[email protected]>

* Add Test CI

Signed-off-by: Rajvaibhav Rahane <[email protected]>

* fix: add pytest to test requirements

Signed-off-by: Rajvaibhav Rahane <[email protected]>

---------

Signed-off-by: Rajvaibhav Rahane <[email protected]>

* Change test config to setup.cfg

Signed-off-by: Rajvaibhav Rahane <[email protected]>

* nit: delete renamed folders, fix placeholder test

Signed-off-by: Rajvaibhav Rahane <[email protected]>

---------

Signed-off-by: Rajvaibhav Rahane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants