Skip to content

Modified index build data types and expected values to match API contract#18

Merged
navneet1v merged 1 commit intoopensearch-project:mainfrom
rchitale7:data_type_changes
Mar 4, 2025
Merged

Modified index build data types and expected values to match API contract#18
navneet1v merged 1 commit intoopensearch-project:mainfrom
rchitale7:data_type_changes

Conversation

@rchitale7
Copy link
Member

Description

  • Removed float16, byte, and binary from supported vector data types
  • Removed cosine, l1, linf, and hamming from supported space types
  • Modified API contract to return file_path instead of index_path
  • Updated upload_index task to always upload a knn index with the same path as the vector_path, except with a different file extension, based on the engine.
    • This change was technically not necessary, but I felt that it makes the knn index path more predictable

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@rchitale7 rchitale7 added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 4, 2025
@rchitale7 rchitale7 self-assigned this Mar 4, 2025
@rchitale7 rchitale7 marked this pull request as ready for review March 4, 2025 19:19
@navneet1v navneet1v merged commit 1f19156 into opensearch-project:main Mar 4, 2025
4 checks passed
@rchitale7 rchitale7 deleted the data_type_changes branch March 7, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants