Added dockerfile for core index build library #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rohan Chitale <[email protected]>
|
This is a work in progress. Leaving as draft to get some feedback |
navneet1v
reviewed
Mar 5, 2025
| @@ -0,0 +1,11 @@ | |||
| FROM rchitale7/remote-index-build-service:faiss-base | |||
There was a problem hiding this comment.
lets add a TODO on this so that we can replace the faiss base image with the actual image we need.
|
|
||
| WORKDIR /app | ||
|
|
||
| COPY core/requirements.txt /app/requirements.txt |
There was a problem hiding this comment.
Suggested change
| COPY core/requirements.txt /app/requirements.txt | |
| COPY core/requirements.txt /app/core/requirements.txt |
| @@ -0,0 +1,11 @@ | |||
| FROM rchitale7/remote-index-build-service:faiss-base | |||
|
|
|||
| WORKDIR /app | |||
There was a problem hiding this comment.
Suggested change
| WORKDIR /app | |
| WORKDIR /remote_vector_index_build |
Signed-off-by: Rohan Chitale <[email protected]>
Signed-off-by: Rohan Chitale <[email protected]>
Signed-off-by: Rohan Chitale <[email protected]>
|
closing this PR in favor of #41, which contains the dockerfile and run_tasks function |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added components to create
coreRemote Vector Index Builder docker image. This PR is a work in progress, and is still awaiting completion of thebuild_indextask targeted by this PR: #16. It also needs to use a different base image.I pulled the current base image from here: https://hub.docker.com/r/rchitale7/remote-index-build-service/tags
Issues Resolved
Related to this issue: #20
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.