Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Separated DLS/FLS privilege evaluation from action privilege evaluation #4539

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport dabff35 from #4490.

…on (#4490)

Signed-off-by: Nils Bandener <[email protected]>
(cherry picked from commit dabff35)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 89.09091% with 6 lines in your changes missing coverage. Please review.

Project coverage is 65.18%. Comparing base (6b31b04) to head (08d17ee).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x    #4539      +/-   ##
==========================================
+ Coverage   65.11%   65.18%   +0.06%     
==========================================
  Files         312      313       +1     
  Lines       21905    21942      +37     
  Branches     3554     3556       +2     
==========================================
+ Hits        14263    14302      +39     
+ Misses       5860     5857       -3     
- Partials     1782     1783       +1     
Files Coverage Δ
...ity/configuration/DlsFilterLevelActionHandler.java 57.60% <100.00%> (+0.39%) ⬆️
...rch/security/configuration/DlsFlsRequestValve.java 0.00% <ø> (ø)
...search/security/configuration/DlsFlsValveImpl.java 59.93% <100.00%> (+0.88%) ⬆️
...org/opensearch/security/filter/SecurityFilter.java 65.87% <100.00%> (-0.32%) ⬇️
...curity/privileges/PrivilegesEvaluationContext.java 100.00% <100.00%> (ø)
.../opensearch/security/OpenSearchSecurityPlugin.java 84.37% <50.00%> (+0.02%) ⬆️
...curity/privileges/PrivilegesEvaluatorResponse.java 80.95% <0.00%> (-1.66%) ⬇️
...earch/security/privileges/PrivilegesEvaluator.java 71.87% <71.42%> (-0.42%) ⬇️

... and 4 files with indirect coverage changes

@cwperks cwperks merged commit 1f7238e into 2.x Jul 10, 2024
88 checks passed
@cwperks cwperks deleted the backport/backport-4490-to-2.x branch July 10, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants