Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix 'integTest' not called with test workflows during release… #4865

Closed
wants to merge 1 commit into from

Conversation

derek-ho
Copy link
Collaborator

… (#4814)"

This reverts commit a1816fb.

Description

[Describe what this change achieves]

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
  • Why these changes are required?
  • What is the old behavior before changes and new behavior after changes?

Issues Resolved

[List any issues this PR will resolve]

Is this a backport? If so, please add backport PR # and/or commits #, and remove backport-failed label from the original PR.

Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta
Copy link
Collaborator

reta commented Oct 30, 2024

Sorry @derek-ho , why it is reverted?

@cwperks
Copy link
Member

cwperks commented Oct 31, 2024

Sorry @derek-ho , why it is reverted?

Tests with the integTest task should run against a cluster configured by opensearch-build and the integrationTest task of the security plugin spins up in-memory test clusters.

The integTest task is trigged by release tests to run against a release candidate with all plugins installed.

@derek-ho I think this PR should also add back in the integtest.sh file from https://github.com/opensearch-project/security/pull/3844/files#diff-7c96c1263d98396b99fc05f50f3c1282760df88d08a220f7a878d97ebe8cb1db

@reta
Copy link
Collaborator

reta commented Oct 31, 2024

Superseded by #4866?

@cwperks
Copy link
Member

cwperks commented Oct 31, 2024

Superseded by #4866?

Yes, this can be closed. @reta Please see my replies to Nils' comments on #4866

@cwperks cwperks closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants