Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sample.pem and test-kirk.jks in bwc-tests #4877

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Nov 5, 2024

Description

The certs in the bwc-tests resources directory were replace, but the corresponding sample.pem and test-kirk.jks files were not replaced.

I am planning to go through different plugin repositories that have the demo certs checked in, and replace the checked in certs with a task to download certs from the security repo. See example PR in async search plugin: opensearch-project/asynchronous-search#650

In order to replace the certs, the security plugin needs the up-to-date sample.pem and test-kirk.jks files.

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Maintenance

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.70%. Comparing base (863b990) to head (63a9447).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4877      +/-   ##
==========================================
- Coverage   69.89%   69.70%   -0.20%     
==========================================
  Files         320      320              
  Lines       21688    21688              
  Branches     3460     3460              
==========================================
- Hits        15159    15117      -42     
- Misses       4735     4782      +47     
+ Partials     1794     1789       -5     

see 11 files with indirect coverage changes

@willyborankin willyborankin added the backport 2.x backport to 2.x branch label Nov 5, 2024
@reta reta merged commit 1c898dc into opensearch-project:main Nov 5, 2024
42 of 43 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 5, 2024
Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit 1c898dc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants