-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for certificates hot reload #4880
Open
willyborankin
wants to merge
1
commit into
opensearch-project:main
Choose a base branch
from
willyborankin:ssl-hot-reload
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add support for certificates hot reload #4880
willyborankin
wants to merge
1
commit into
opensearch-project:main
from
willyborankin:ssl-hot-reload
+362
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willyborankin
requested review from
cwperks,
DarshitChanpura,
derek-ho,
nibix,
peternied,
RyanL1997 and
reta
as code owners
November 6, 2024 20:32
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4880 +/- ##
==========================================
- Coverage 71.45% 71.42% -0.03%
==========================================
Files 334 334
Lines 22509 22543 +34
Branches 3582 3586 +4
==========================================
+ Hits 16084 16102 +18
- Misses 4633 4645 +12
- Partials 1792 1796 +4
|
@willyborankin Can you open a documentation PR for this as well since this adds a new setting? |
cwperks
reviewed
Nov 7, 2024
cwperks
reviewed
Nov 7, 2024
src/main/java/org/opensearch/security/OpenSearchSecurityPlugin.java
Outdated
Show resolved
Hide resolved
cwperks
reviewed
Nov 7, 2024
src/test/java/org/opensearch/security/ssl/SslSettingsManagerReloadListenerTest.java
Show resolved
Hide resolved
Added support for certificates hot reload issue: 4427 Signed-off-by: Andrey Pleskach <[email protected]>
willyborankin
force-pushed
the
ssl-hot-reload
branch
from
November 12, 2024 19:15
f6c992c
to
b1f826c
Compare
cwperks
approved these changes
Nov 14, 2024
RyanL1997
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for certificates hot reload
Issues Resolved
#4427
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.