Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log io.netty.internal.tcnative.SSLContext availability warning only when OpenSSL is explicitly enabled but not available #4901

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented Nov 13, 2024

Description

Log io.netty.internal.tcnative.SSLContext availability warning only when OpenSSL is explicitly enabled but not available

Issues Resolved

Closes #4881

Testing

The log is clean now , will be printed out if SECURITY_SSL_HTTP_ENABLE_OPENSSL_IF_AVAILABLE or SECURITY_SSL_TRANSPORT_ENABLE_OPENSSL_IF_AVAILABLE is enabled.

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta reta added v2.19.0 Issues targeting release v2.19.0 bug Something isn't working v3.0.0 backport 2.x backport to 2.x branch labels Nov 13, 2024
…hen OpenSSL is explicitly enabled but not available

Signed-off-by: Andriy Redko <[email protected]>
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.41%. Comparing base (9b67d54) to head (966634d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rg/opensearch/security/ssl/SslSettingsManager.java 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4901      +/-   ##
==========================================
- Coverage   71.45%   71.41%   -0.05%     
==========================================
  Files         334      334              
  Lines       22509    22515       +6     
  Branches     3582     3585       +3     
==========================================
- Hits        16084    16079       -5     
- Misses       4633     4643      +10     
- Partials     1792     1793       +1     
Files with missing lines Coverage Δ
...rg/opensearch/security/ssl/SslSettingsManager.java 71.15% <87.50%> (-0.85%) ⬇️

... and 3 files with indirect coverage changes

@willyborankin willyborankin merged commit 4aa7b1c into opensearch-project:main Nov 14, 2024
41 of 42 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 14, 2024
…hen OpenSSL is explicitly enabled but not available (#4901)

Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit 4aa7b1c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch bug Something isn't working v2.19.0 Issues targeting release v2.19.0 v3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

java.lang.ClassNotFoundException: io.netty.internal.tcnative.SSLContext during start of v2.18
3 participants