-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow in each repo to apply Konflux manifests on changes #305
base: main
Are you sure you want to change the base?
Add workflow in each repo to apply Konflux manifests on changes #305
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
why not calling the existing workflow in this repo instead of duplicating it everywhere? That would solve also the possibility for CI config to be different when merging PRs so from each repo we would call the generate CI and Konflux apply |
Similar to what we already do for SO, I think we discussed that as the approach we would have taken openshift-knative/serverless-operator@45eccfe |
Not sure if I understand you correctly, but isn't this what I am proposing in my PR? I made the existing workflow to apply the konflux manifests "reusable" and only add a new workflow to the other repos, which calls this workflow:
This allows us to still manage the core workflow in this repo and run the workflow only when it's needed (on pushes to the downstream repos) |
b29dde5
to
40b6423
Compare
40b6423
to
5bd1018
Compare
5bd1018
to
f2813e4
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
.konflux/
directory in the repositories and does not need the periodic runs from hack repo anymore/hold
as we need to move the
KONFLUX_SA_TOKEN
secret from the hack repo to the org (when we agreed on this PR)