Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow in each repo to apply Konflux manifests on changes #305

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

creydr
Copy link
Member

@creydr creydr commented Sep 30, 2024

  • add a reusable action to apply the Konflux manifests
  • Adds a workflow to each repo & branch which have Konflux enabled calling the above reusable action. This allows to apply the manifests directly after changes in the .konflux/ directory in the repositories and does not need the periodic runs from hack repo anymore

/hold
as we need to move the KONFLUX_SA_TOKEN secret from the hack repo to the org (when we agreed on this PR)

Copy link

openshift-ci bot commented Sep 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member

pierDipi commented Sep 30, 2024

why not calling the existing workflow in this repo instead of duplicating it everywhere? That would solve also the possibility for CI config to be different when merging PRs so from each repo we would call the generate CI and Konflux apply

@pierDipi
Copy link
Member

pierDipi commented Sep 30, 2024

Similar to what we already do for SO, I think we discussed that as the approach we would have taken openshift-knative/serverless-operator@45eccfe

@creydr
Copy link
Member Author

creydr commented Sep 30, 2024

why not calling the existing workflow in this repo instead of duplicating it everywhere? That would solve also the possibility for CI config to be different when merging PRs so from each repo we would call the generate CI and Konflux apply

Not sure if I understand you correctly, but isn't this what I am proposing in my PR? I made the existing workflow to apply the konflux manifests "reusable" and only add a new workflow to the other repos, which calls this workflow:

uses: openshift-knative/hack/.github/workflows/reusable-apply-konflux-manifests.yaml@main

This allows us to still manage the core workflow in this repo and run the workflow only when it's needed (on pushes to the downstream repos)

@creydr creydr force-pushed the apply-konflux-manifests-on-changes branch from b29dde5 to 40b6423 Compare October 1, 2024 06:10
@openshift-merge-robot openshift-merge-robot added the needs-rebase The PR needs to have conflicts fixed label Oct 10, 2024
@creydr creydr force-pushed the apply-konflux-manifests-on-changes branch from 40b6423 to 5bd1018 Compare October 31, 2024 11:30
@openshift-merge-robot openshift-merge-robot removed the needs-rebase The PR needs to have conflicts fixed label Oct 31, 2024
@creydr creydr force-pushed the apply-konflux-manifests-on-changes branch from 5bd1018 to f2813e4 Compare October 31, 2024 11:33
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase The PR needs to have conflicts fixed label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved do-not-merge/hold needs-rebase The PR needs to have conflicts fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants