Skip to content

Commit

Permalink
Remove POST only requests and add all host matches (#7)
Browse files Browse the repository at this point in the history
Signed-off-by: Pierangelo Di Pilato <[email protected]>
  • Loading branch information
pierDipi authored Jul 31, 2023
1 parent 192ef16 commit d7cdb2f
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 7 deletions.
1 change: 0 additions & 1 deletion templates/common-allow-via-knative-serving.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ spec:
- "*.{{ $v }}.svc"
- "*.{{ $v }}.svc.{{ $.Values.cluster.domain }}"
{{- end }}
methods: [ "POST" ]
when:
- key: request.headers[Kn-Namespace]
values:
Expand Down
1 change: 0 additions & 1 deletion templates/eventing-allow-ns-to-kafka-broker-reply.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ spec:
{{- range $v := $.Values.namespaces }}
- "/{{ $v }}/*"
{{- end }}
methods: [ "POST" ]
when:
- key: request.headers[Kn-Namespace]
values:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ spec:
{{- range $v := $.Values.namespaces }}
- "/{{ $v }}/*"
{{- end }}
methods: [ "POST" ]
when:
- key: request.headers[Kn-Namespace]
values:
Expand Down
8 changes: 4 additions & 4 deletions templates/eventing-allow-to-knative-eventing-receiver.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@ spec:
{{- range $v := $.Values.namespaces }}
- "/{{ $v }}/*"
{{- end }}
methods: [ "POST" ]
- operation:
hosts:
{{- range $v := $.Values.namespaces }}
- "*.{{ $v }}"
- "*.{{ $v }}.svc"
- "*.{{ $v }}.svc.{{ $.Values.cluster.domain }}"
{{- end }}
methods: [ "POST" ]
- from:
- source:
namespaces: [ "knative-eventing" ]
Expand All @@ -44,9 +44,10 @@ spec:
- operation:
hosts:
{{- range $v := $.Values.namespaces }}
- "*.{{ $v }}"
- "*.{{ $v }}.svc"
- "*.{{ $v }}.svc.{{ $.Values.cluster.domain }}"
{{- end }}
methods: [ "POST" ]
when:
- key: request.headers[Kn-Namespace]
values:
Expand All @@ -66,7 +67,6 @@ spec:
{{- range $v := $.Values.namespaces }}
- "/{{ $v }}/*"
{{- end }}
methods: [ "POST" ]
when:
- key: request.headers[Kn-Namespace]
values:
Expand Down

0 comments on commit d7cdb2f

Please sign in to comment.