Skip to content

kcli wrapper role #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ccardenosa
Copy link
Collaborator

No description provided.

Signed-off-by: Carlos Cardenosa <[email protected]>
@openshift-ci openshift-ci bot requested review from cplacani and eifrach May 9, 2025 16:42
Copy link

openshift-ci bot commented May 9, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ccardenosa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ccardenosa
Copy link
Collaborator Author

/assign @kononovn

@eifrach
Copy link
Contributor

eifrach commented May 11, 2025

@ccardenosa can we have a description and explanation for what is this for ?

we are using redhat roles for cluster deployment what do we need to add Kcli here?

@ccardenosa
Copy link
Collaborator Author

Thank you for your comment @eifrach.

This was a role I already had and used at the beginning of the ZTP task, when we had not yet agreed and implemented the structure we would use. I am now sharing it with @kononovn, to readapt it by removing kcli from the equation (if it is worth it) or to take ideas as a starting point for the new roles and playbooks that need to be done to deploy virtualized Hubs.

Our plan is not to merge it as is.

@eifrach
Copy link
Contributor

eifrach commented May 12, 2025

Thank you for your comment @eifrach.

This was a role I already had and used at the beginning of the ZTP task, when we had not yet agreed and implemented the structure we would use. I am now sharing it with @kononovn, to readapt it by removing kcli from the equation (if it is worth it) or to take ideas as a starting point for the new roles and playbooks that need to be done to deploy virtualized Hubs.

Our plan is not to merge it as is.

first, I am a big fan of KCLI and AICLI - great tool, and great support from the maintainer
two, great idea and great work.

but, I see here a few issues

  1. we have now two solution to create the same thing, we should pick one and not use both
  2. KCLI is not support by RadHat and we should try to give the generic tools which also supported and maintained ( for future support and features )
  3. This Role majority is running shell scripts which have a lot of downsides when using Ansible ( error handling, output, debugging etc) better to use a shell /python script instead

@natifridman do you want to give your option also here?

@natifridman
Copy link
Collaborator

I think the plan was to try using the roles we have for virtualized clusters.
I guess this PR is just for comparing what we currently have and seeing if there are any gaps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants