Starting Metadata service automatically #260
Conversation
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @mmorency2021. Thanks for your PR. I'm waiting for a openshift-kni member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci
bot
added
the
needs-ok-to-test
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
|
Please take a look at the comments on #132 - according to the comments there, the token is not necessary and the image isn't required in the Inventory CR. |
|
/cc @alegacy |
config/manager/metadata-server.yaml
Outdated
| spec: | ||
| alarmSubscriptionServerConfig: | ||
| enabled: false | ||
| cloudId: ae6bd821-a4a4-4e53-89d1-94609968e40e |
There was a problem hiding this comment.
This cloudId is meant to be the globalCloudId... as discussed internally this should be made optionally and excluded from this CR and only provided by the end user when the system is ready to be registered with the SMO, this is because the system cannot register with the SMO until the administrator has setup this cloud in the SMO and has acquired the globalCloudId.
So i think what should happen here is that this field be made optional, and renamed to globalCloudId so that its intent is clear.
config/manager/metadata-server.yaml
Outdated
There was a problem hiding this comment.
This file should probably be named inventory.yaml since metadata-server is only one of the servers being started, but not the entire purpose of this CR.
Makefile
Outdated
|
|
||
| ifndef ignore-not-found | ||
| ignore-not-found = false | ||
| ignore-not-found = true |
There was a problem hiding this comment.
This should be removed before merging... and can be specified at the command line like this:
make IMAGE_TAG_BASE=<your repo name here> undeploy docker-push install deploy ignore-not-found=true
Makefile
Outdated
|
|
||
| # getting the cloud id and the IngressHost | ||
|
|
||
| CLOUD_ID := $(shell oc get clusterversion -o jsonpath='{.items[].spec.clusterID}{"\n"}') |
There was a problem hiding this comment.
These new lines can all be removed. See comments in the metadata-server.yaml file.
config/manager/metadata-server.yaml
Outdated
| app.kubernetes.io/managed-by: kustomize | ||
| app.kubernetes.io/name: orano2ims | ||
| app.kubernetes.io/part-of: oran-o2ims | ||
| name: metadata-server |
There was a problem hiding this comment.
This name should be changed to something more generic... like default or cluster which are two examples that seem to be used by other operators that automatically create an instance of themselves. I prefer default... @bartwensley @browsell thoughts?
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is part of ORAN - Project infrastructure - Automatically start services
https://issues.redhat.com/browse/MGMT-18997
Using Target deploy to install operator and enable services
Using clusterID to deploy meta data server , user can edit later on the CR to add more parameters