Skip to content

[release-4.16]: Onboard noderesourcetopology scheduler to Konflux #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rbaturov
Copy link

@rbaturov rbaturov commented Jun 5, 2025

  • Add dockerfile for konflux builds.
  • Add initial tekton files for build pipelines.
  • Enable hermetic builds.
  • Add build pipeline file containing metadata added to avoid code duplication across tekton files.
  • Add owners file to manage approvers for konflux configuration.

Copy link

openshift-ci bot commented Jun 5, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2025
@rbaturov rbaturov force-pushed the onboard-konflux-4-16 branch 2 times, most recently from c90e8f3 to 4c5156e Compare June 5, 2025 07:10
@rbaturov rbaturov marked this pull request as ready for review June 5, 2025 07:47
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2025
@openshift-ci openshift-ci bot requested review from ffromani and swatisehgal June 5, 2025 07:48
@rbaturov rbaturov changed the title Onboard noderesourcetopology scheduler to Konflux - 4.16 [release-4.16]: Onboard noderesourcetopology scheduler to Konflux Jun 5, 2025
@rbaturov rbaturov force-pushed the onboard-konflux-4-16 branch from 4c5156e to b3c1893 Compare June 9, 2025 07:15
@rbaturov rbaturov force-pushed the onboard-konflux-4-16 branch from b3c1893 to a9beb15 Compare June 10, 2025 14:07
@rbaturov
Copy link
Author

/retest

@rbaturov rbaturov force-pushed the onboard-konflux-4-16 branch 8 times, most recently from d54d45f to 302824a Compare June 15, 2025 18:50
@shajmakh
Copy link
Member

Thanks Ronny for working on this.
I'm usually in favor of squashing all the commits related to pure konflux files like tekton, konflux dockerfile and so on. The onboarding is first introduced in this PR so I don't see the need to file different commits that would update the same new file besides making it easier for reviews while the PR is open. If I still see the need for highlighting some updates for the future I'd do that in the commit message. I'll leave that up to you if you see keeping the commits unsquashed is essential.

@rbaturov rbaturov force-pushed the onboard-konflux-4-16 branch from 302824a to fa40b7b Compare June 17, 2025 10:33
@rbaturov
Copy link
Author

depends on #358

@rbaturov
Copy link
Author

rbaturov commented Jun 17, 2025

Will rebase now as #358 is merged

@rbaturov
Copy link
Author

Thanks Ronny for working on this. I'm usually in favor of squashing all the commits related to pure konflux files like tekton, konflux dockerfile and so on. The onboarding is first introduced in this PR so I don't see the need to file different commits that would update the same new file besides making it easier for reviews while the PR is open. If I still see the need for highlighting some updates for the future I'd do that in the commit message. I'll leave that up to you if you see keeping the commits unsquashed is essential.

The separation is primarily for the sake of making the review process easier indeed, Like we do in any other PR, we don't squash as well, so why does this differ? In the end, this will be merged as one merged PR commit, don't it?

red-hat-konflux and others added 5 commits June 17, 2025 14:36
These are initial configuration that has been generated by the konflux bot, for both on pull-request and push.

Signed-off-by: red-hat-konflux <[email protected]>
More information about the hermetic builds:
https://konflux-ci.dev/docs/building/hermetic-builds/

Signed-off-by: Ronny Baturov <[email protected]>
This is needed to onboard this container to konflux.

Signed-off-by: Ronny Baturov <[email protected]>
@rbaturov rbaturov force-pushed the onboard-konflux-4-16 branch from fa40b7b to 8db55f2 Compare June 17, 2025 11:36
@yanirq
Copy link
Member

yanirq commented Jun 17, 2025

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2025
Copy link

openshift-ci bot commented Jun 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rbaturov, yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 568f1ca into openshift-kni:release-4.16 Jun 17, 2025
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants