[release-4.16]: Onboard noderesourcetopology scheduler to Konflux #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rbaturov The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
These are initial configuration that has been generated by the konflux bot, for both on pull-request and push. Signed-off-by: red-hat-konflux <[email protected]>
More information about the hermetic builds: https://konflux-ci.dev/docs/building/hermetic-builds/ Signed-off-by: Ronny Baturov <[email protected]>
rbaturov
force-pushed
the
onboard-konflux-4-16
branch
2 times, most recently
from
c90e8f3 to
4c5156e
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
rbaturov
changed the title
Signed-off-by: Ronny Baturov <[email protected]>
rbaturov
force-pushed
the
onboard-konflux-4-16
branch
from
4c5156e to
b3c1893
Compare
yanirq
reviewed
Jun 10, 2025
| @@ -0,0 +1,28 @@ | |||
| ARG RHEL_VERSION=9.4 | |||
|
|
|||
| FROM brew.registry.redhat.io/rh-osbs/openshift-golang-builder:v1.22 AS builder | |||
There was a problem hiding this comment.
- In 4.16 we were using golang builder 1.21 , please check and align
- We would usually want to pin the golang builder to the rhel version and also add a tag , for example:
FROM brew.registry.redhat.io/rh-osbs/openshift-golang-builder:rhel_9_golang_1.21@sha256:218ece7acb0c215d0ec54e690446209fe64a6080a7202a54ef3945b152f4fc89 as builder
This is needed to onboard this container to konflux. Signed-off-by: Ronny Baturov <[email protected]>
rbaturov
force-pushed
the
onboard-konflux-4-16
branch
from
b3c1893 to
a9beb15
Compare
yanirq
reviewed
Jun 11, 2025
| @@ -0,0 +1,26 @@ | |||
| FROM brew.registry.redhat.io/rh-osbs/openshift-golang-builder:rhel_9_golang_1.22@sha256:9febad53eab6f5b6d1f9a32c7b5f22afdebd6d7735e08f068e0dcbe2ffa6ca64 as builder | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.