Skip to content

[release-4.14]: Onboard noderesourcetopology scheduler to Konflux #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: release-4.14
Choose a base branch
from

Conversation

rbaturov
Copy link

@rbaturov rbaturov commented Jun 5, 2025

  • Add dockerfile for konflux builds.
  • Add initial tekton files for build pipelines.
  • Enable hermetic builds.
  • Add build pipeline file containing metadata added to avoid code duplication across tekton files.
  • Add owners file to manage approvers for konflux configuration.

red-hat-konflux and others added 3 commits June 5, 2025 10:16
These are initial configuration that has been generated by the konflux bot, for both on pull-request and push.

Signed-off-by: red-hat-konflux <[email protected]>
More information about the hermetic builds:
https://konflux-ci.dev/docs/building/hermetic-builds/

Signed-off-by: Ronny Baturov <[email protected]>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2025
Copy link

openshift-ci bot commented Jun 5, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Jun 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rbaturov
Once this PR has been reviewed and has the lgtm label, please assign yanirq for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rbaturov rbaturov marked this pull request as ready for review June 5, 2025 07:47
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2025
@openshift-ci openshift-ci bot requested review from Tal-or and yanirq June 5, 2025 07:48
@rbaturov rbaturov changed the title Onboard noderesourcetopology scheduler to Konflux - 4.14 [release-4.14]: Onboard noderesourcetopology scheduler to Konflux Jun 5, 2025
@rbaturov rbaturov force-pushed the onboard-konflux-4-14 branch from d4a9ec7 to 6aad914 Compare June 9, 2025 07:14
@@ -0,0 +1,28 @@
ARG RHEL_VERSION=9.4

FROM brew.registry.redhat.io/rh-osbs/openshift-golang-builder:v1.20 AS builder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would usually want to pin the golang builder to the rhel version and also add a tag , for example:
FROM brew.registry.redhat.io/rh-osbs/openshift-golang-builder:rhel_9_golang_1.20@sha256:f814c21d78b9c98efd8cab17ead9d6fd1480341b5f7664fe5c75606b8d8f2be2 as builder

This is needed to onboard this container to konflux.

Signed-off-by: Ronny Baturov <[email protected]>
@rbaturov rbaturov force-pushed the onboard-konflux-4-14 branch from 6aad914 to 2c8c511 Compare June 10, 2025 14:08

COPY . .

RUN GOEXPERIMENT=strictfipsruntime GOOS=linux CGO_ENABLED=1 go build -tags strictfipsruntime -o bin/noderesourcetopology-plugin cmd/noderesourcetopology-plugin/main.go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we required to add the -ldflags option here ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants