-
Notifications
You must be signed in to change notification settings - Fork 4
[release-4.14]: Onboard noderesourcetopology scheduler to Konflux #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-4.14
Are you sure you want to change the base?
[release-4.14]: Onboard noderesourcetopology scheduler to Konflux #335
Conversation
These are initial configuration that has been generated by the konflux bot, for both on pull-request and push. Signed-off-by: red-hat-konflux <[email protected]>
More information about the hermetic builds: https://konflux-ci.dev/docs/building/hermetic-builds/ Signed-off-by: Ronny Baturov <[email protected]>
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rbaturov The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Ronny Baturov <[email protected]>
d4a9ec7
to
6aad914
Compare
@@ -0,0 +1,28 @@ | |||
ARG RHEL_VERSION=9.4 | |||
|
|||
FROM brew.registry.redhat.io/rh-osbs/openshift-golang-builder:v1.20 AS builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would usually want to pin the golang builder to the rhel version and also add a tag , for example:
FROM brew.registry.redhat.io/rh-osbs/openshift-golang-builder:rhel_9_golang_1.20@sha256:f814c21d78b9c98efd8cab17ead9d6fd1480341b5f7664fe5c75606b8d8f2be2 as builder
This is needed to onboard this container to konflux. Signed-off-by: Ronny Baturov <[email protected]>
6aad914
to
2c8c511
Compare
|
||
COPY . . | ||
|
||
RUN GOEXPERIMENT=strictfipsruntime GOOS=linux CGO_ENABLED=1 go build -tags strictfipsruntime -o bin/noderesourcetopology-plugin cmd/noderesourcetopology-plugin/main.go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we required to add the -ldflags
option here ?
Uh oh!
There was an error while loading. Please reload this page.