Skip to content

[release-4.19]: pin Dockerfile images #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release-4.19
Choose a base branch
from

Conversation

rbaturov
Copy link

we prefer to pin the image digests as currently done for d/s builts.

we prefer to pin the image digests as currently done for d/s builts.

Signed-off-by: Ronny Baturov <[email protected]>
@openshift-ci openshift-ci bot requested review from ffromani and swatisehgal June 10, 2025 13:50
Copy link

openshift-ci bot commented Jun 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rbaturov
Once this PR has been reviewed and has the lgtm label, please assign ffromani for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rbaturov rbaturov changed the base branch from master to release-4.19 June 10, 2025 13:51
@rbaturov rbaturov changed the title [KNI]: pin Dockerfile images [release-4.19]: pin Dockerfile images Jun 10, 2025
@shajmakh
Copy link
Member

For d/s builds we had an automation that would update the digests automatically, I'm unaware that mintmaker support such thing for dockerfiles/rpm lockfiles that are not under the root directory. which means this digest will be there unless manually bumped, do we want that?

@yanirq
Copy link
Member

yanirq commented Jun 11, 2025

For d/s builds we had an automation that would update the digests automatically, I'm unaware that mintmaker support such thing for dockerfiles/rpm lockfiles that are not under the root directory. which means this digest will be there unless manually bumped, do we want that?

@shajmakh for Dockerfiles not under root directory Mintmaker will do the digests updates , see for example https://github.com/openshift-kni/numaresources-operator/pull/1320/files

For rpm lockfiles that are not under root there is no automated support yet, so for the moment we will update manually until we get support for subdirs OR decide later on to move the lockfiles to root.

@rbaturov
Copy link
Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants