Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MetalLB: Remove "\" from SKIP var in E2E tests script #1339

Closed
wants to merge 1 commit into from
Closed

MetalLB: Remove "\" from SKIP var in E2E tests script #1339

wants to merge 1 commit into from

Conversation

sabinaaledort
Copy link
Contributor

@sabinaaledort sabinaaledort commented Jan 25, 2022 •
edited
Loading

Since metallb/metallb#1145 we don't need to explicitly set "" in the SKIP.

@openshift-ci openshift-ci bot requested review from fedepaol and russellb January 25, 2022 08:15
@sabinaaledort sabinaaledort changed the title MetalLB: Remove "\" from SKIP var in E2E tests script MetalLB: Update E2E tests script Jan 25, 2022
@sabinaaledort sabinaaledort changed the title MetalLB: Update E2E tests script MetalLB: Remove "\" from SKIP var in E2E tests script Jan 25, 2022
@sabinaaledort
MetalLB: Remove "\" from SKIP var in E2E tests script
9b326fa 
Since metallb/metallb#1145 we don't need to
explicitly set "\" in the SKIP.
@fedepaol
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jan 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fedepaol

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2022
@fedepaol
Copy link
Contributor

/retest

3 similar comments
@fedepaol
Copy link
Contributor

/retest

@sabinaaledort
Copy link
Contributor Author

/retest

@fedepaol
Copy link
Contributor

/retest

@msherif1234
Copy link
Contributor

/test e2e-metal-ipi-ovn-dualstack

@sabinaaledort
Copy link
Contributor Author

/retest

@fedepaol
Copy link
Contributor

/test e2e-metal-ipi-ovn-dualstack

@msherif1234
Copy link
Contributor

/retest

2 similar comments
@msherif1234
Copy link
Contributor

/retest

@sabinaaledort
Copy link
Contributor Author

/retest

@sabinaaledort
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 22, 2022

@sabinaaledort: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack 9b326fa link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-metal-ipi 9b326fa link true /test e2e-metal-ipi
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 9b326fa link true /test e2e-metal-ipi-serial-ovn-ipv6
ci/prow/e2e-metal-ipi-serial-ipv4 9b326fa link true /test e2e-metal-ipi-serial-ipv4
ci/prow/e2e-metal-ipi-ovn-ipv6 9b326fa link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-metal-ipi-proxy-ipv4 9b326fa link true /test e2e-metal-ipi-proxy-ipv4
ci/prow/e2e-metal-ipi-proxy-ipv6 9b326fa link true /test e2e-metal-ipi-proxy-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sabinaaledort
Copy link
Contributor Author

This is not relevant anymore since the MetalLB deployment scripts for OCP CI are now part of the openshift/metallb repo:
https://github.com/openshift/metallb/tree/main/openshift-ci

#1390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedepaol fedepaol Awaiting requested review from fedepaol

@russellb russellb Awaiting requested review from russellb

Assignees

@fedepaol fedepaol

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sabinaaledort @fedepaol @msherif1234