assisted-service: Add imageStorage to the service configuration#1365
Conversation
|
@mkowalski: GitHub didn't allow me to request PR reviews from the following users: mresvanis. Note that only openshift-metal3 members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
#1364 is needed for this PR to restore a proper functionality of |
|
/cc @flaper87 |
|
/lgtm |
|
/retest |
|
/retest |
|
/retest-required |
mkowalski
force-pushed
the
assisted-ASC-change
branch
from
0ae5b8c to
aa139d5
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hardys The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
mkowalski
force-pushed
the
assisted-ASC-change
branch
from
aa139d5 to
3d4c5b6
Compare
|
/retest-required |
With openshift/assisted-service#3067 we have introduced an `imageStorage` configuration option that needs to be set in the AgentServiceConfig for Infrastructure Operator. This PR adds the configuration, so that `make assisted` target can deploy the operator seamlessly.
mkowalski
force-pushed
the
assisted-ASC-change
branch
from
3d4c5b6 to
9dcc3cb
Compare
|
/lgtm |
|
/retest |
|
@mkowalski: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit be7d6e4
into
openshift-metal3:master
5 participants
With openshift/assisted-service#3067 we have
introduced an
imageStorageconfiguration option that needs to be setin the AgentServiceConfig for Infrastructure Operator.
This PR adds the configuration, so that
make assistedtarget candeploy the operator seamlessly.
/cc @mresvanis