Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to use addon service API for addons function #690

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Update to use addon service API for addons function #690

merged 1 commit into from
Nov 1, 2024

Conversation

weherdh
Copy link
Contributor

@weherdh weherdh commented Oct 28, 2024

This is to resolve OCM-1983, to update the cli to list addons with ocm-addon-service API

@weherdh weherdh marked this pull request as draft October 28, 2024 01:00
@ashishmax31
Copy link

This looks good. @ciaranRoche Are there any other places where we need to switch over the API?

venkateshsredhat
venkateshsredhat reviewed Oct 30, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
ciaranRoche
ciaranRoche reviewed Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@ciaranRoche ciaranRoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will also need to update the addons in pkg/url_expander.go

pkg/cluster/cluster.go Outdated Show resolved Hide resolved
@weherdh weherdh marked this pull request as ready for review October 31, 2024 00:08
@weherdh
Copy link
Contributor Author

weherdh commented Oct 31, 2024

You will also need to update the addons in pkg/url_expander.go

Updated

ciaranRoche
ciaranRoche approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@ciaranRoche ciaranRoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ciaranRoche ciaranRoche merged commit 66e2db1 into openshift-online:main Nov 1, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@venkateshsredhat venkateshsredhat venkateshsredhat left review comments

@ciaranRoche ciaranRoche ciaranRoche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weherdh @ashishmax31 @ciaranRoche @venkateshsredhat