Merge pull request #2219 from alebedev87/gwapi-controller-featuregate

NE-1954: Introduce GatewayAPIController feature gate
openshift · Mar 5, 2025 · b8da3bf · b8da3bf
2 parents 529099f + 114523d
commit b8da3bf
Show file tree

Hide file tree

Showing 8 changed files with 32 additions and 0 deletions.
diff --git a/features.md b/features.md
@@ -28,6 +28,7 @@
 | GCPClusterHostedDNS| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | GCPCustomAPIEndpoints| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | GatewayAPI| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
+| GatewayAPIController| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | HighlyAvailableArbiter| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | ImageStreamImportMode| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |
 | IngressControllerDynamicConfigurationManager| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span>  |

diff --git a/features/features.go b/features/features.go
@@ -796,4 +796,17 @@ var (
 		// the other still in TechPreview.
 		enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
 		mustRegister()
+
+	FeatureGateGatewayAPIController = newFeatureGate("GatewayAPIController").
+					reportProblemsToJiraComponent("Routing").
+					contactPerson("miciah").
+					productScope(ocpSpecific).
+		// Previously, the "GatewayAPI" feature gate managed both the GatewayAPI CRDs
+		// and the Gateway Controller. However, with the introduction of Gateway CRD
+		// lifecycle management (EP#1756), these responsibilities were separated.
+		// A dedicated feature gate now controls the Gateway Controller to distinguish
+		// its production readiness from that of the CRDs.
+		enhancementPR("https://github.com/openshift/enhancements/pull/1756").
+		enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
+		mustRegister()
 )
diff --git a/payload-manifests/featuregates/featureGate-Hypershift-Default.yaml b/payload-manifests/featuregates/featureGate-Hypershift-Default.yaml
@@ -73,6 +73,9 @@
                     {
                         "name": "GatewayAPI"
                     },
+                    {
+                        "name": "GatewayAPIController"
+                    },
                     {
                         "name": "HighlyAvailableArbiter"
                     },

diff --git a/payload-manifests/featuregates/featureGate-Hypershift-DevPreviewNoUpgrade.yaml b/payload-manifests/featuregates/featureGate-Hypershift-DevPreviewNoUpgrade.yaml
@@ -128,6 +128,9 @@
                     {
                         "name": "GatewayAPI"
                     },
+                    {
+                        "name": "GatewayAPIController"
+                    },
                     {
                         "name": "HardwareSpeed"
                     },

diff --git a/payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml b/payload-manifests/featuregates/featureGate-Hypershift-TechPreviewNoUpgrade.yaml
@@ -137,6 +137,9 @@
                     {
                         "name": "GatewayAPI"
                     },
+                    {
+                        "name": "GatewayAPIController"
+                    },
                     {
                         "name": "HardwareSpeed"
                     },

diff --git a/payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml b/payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml
@@ -76,6 +76,9 @@
                     {
                         "name": "GatewayAPI"
                     },
+                    {
+                        "name": "GatewayAPIController"
+                    },
                     {
                         "name": "HighlyAvailableArbiter"
                     },

diff --git a/payload-manifests/featuregates/featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml b/payload-manifests/featuregates/featureGate-SelfManagedHA-DevPreviewNoUpgrade.yaml
@@ -122,6 +122,9 @@
                     {
                         "name": "GatewayAPI"
                     },
+                    {
+                        "name": "GatewayAPIController"
+                    },
                     {
                         "name": "HardwareSpeed"
                     },

diff --git a/payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml b/payload-manifests/featuregates/featureGate-SelfManagedHA-TechPreviewNoUpgrade.yaml
@@ -131,6 +131,9 @@
                     {
                         "name": "GatewayAPI"
                     },
+                    {
+                        "name": "GatewayAPIController"
+                    },
                     {
                         "name": "HardwareSpeed"
                     },
-Original file line number
+Diff line change
@@ Expand Up / @@ -73,6 +73,9 @@ @@
                         {
                             "name": "GatewayAPI"
                         },
+                        {
+                            "name": "GatewayAPIController"
+                        },
                         {
                             "name": "HighlyAvailableArbiter"
                         },
@@ Expand Down @@