Skip to content

Enable MutatingAdmissionPolicy in Dev/TechPreview #2385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enable MutatingAdmissionPolicy in Dev/TechPreview #2385

wants to merge 1 commit into from

Conversation

JoelSpeed
Copy link
Contributor

Follow up to #2349 and openshift/cluster-kube-apiserver-operator#1854

This enables MutatingAdmissionPolicy in the feature gates explicitly for DevPreview and TechPreview

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 1, 2025

Hello @JoelSpeed! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 1, 2025
@openshift-ci openshift-ci bot requested review from deads2k and everettraven July 1, 2025 09:09
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2025
damdo
damdo reviewed Jul 1, 2025
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@damdo
Copy link
Member

damdo commented Jul 1, 2025

/retest

1 similar comment
@damdo
Copy link
Member

damdo commented Jul 1, 2025

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 311324c and 2 for PR HEAD 4575bf2 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9bbe393 and 1 for PR HEAD 4575bf2 in total

@damdo
Copy link
Member

damdo commented Jul 2, 2025

/retest-required

1 similar comment
@JoelSpeed
Copy link
Contributor Author

/retest-required

@damdo
Copy link
Member

damdo commented Jul 2, 2025

Blocked by openshift/hypershift#6362

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b76bb2c and 0 for PR HEAD 4575bf2 in total

@openshift-ci-robot
Copy link

/hold

Revision 4575bf2 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2025
@JoelSpeed
Copy link
Contributor Author

/hold cancel
/retest-required

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 4, 2025

@JoelSpeed: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2025
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damdo damdo damdo left review comments

@deads2k deads2k Awaiting requested review from deads2k

@everettraven everettraven Awaiting requested review from everettraven

Assignees

@damdo damdo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JoelSpeed @damdo @openshift-ci-robot @openshift-merge-robot