MGMT-18464: MGMT-18452: Add validations to make iSCSI disk eligible #819
Conversation
This PR adds 2 checks before making iSSI disks be be eligible as installation disk. MGMT-18464: Check the state of the disk, we need to ensure that it is "running" otherwise the installtion of RHCOS will fail on the disk. MGMT-18464: Check if the discovery as been booted using iBFT, this check ensure that the iSCSI disk is actually a disk on which we will be able to boot from.
openshift-ci-robot
added
the
jira/valid-reference
|
@adriengentil: This pull request references MGMT-18464 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriengentil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #819 +/- ##
==========================================
+ Coverage 59.44% 59.75% +0.30%
==========================================
Files 74 74
Lines 3842 3891 +49
==========================================
+ Hits 2284 2325 +41
- Misses 1389 1393 +4
- Partials 169 173 +4
|
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
| ibftTargetNameFile := filepath.Join(ibftBasePath, file.Name(), "target-name") | ||
| ibftTargetData, err := d.dependencies.ReadFile(ibftTargetNameFile) | ||
| if err != nil { | ||
| logrus.WithError(err).Errorf("Failed to read iSCSI target name in iBFT") |
There was a problem hiding this comment.
| logrus.WithError(err).Errorf("Failed to read iSCSI target name in iBFT") | |
| logrus.WithError(err).Errorf("Failed to read iSCSI target name in iBFT") | |
| continue |
|
@adriengentil: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR adds 2 checks before making iSSI disks be be eligible as
installation disk.
MGMT-18464: Check the state of the disk, we need to ensure that it is
"running" otherwise the installtion of RHCOS will fail on the disk.
MGMT-18464: Check if the discovery as been booted using iBFT, this check
ensure that the iSCSI disk is actually a disk on which we will be able
to boot from.