-
Notifications
You must be signed in to change notification settings - Fork 34
CM-588: Adapt e2e with acme-http01-solver controller args #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
to ensure operator applies those args for cert-manager controller rollout checks Signed-off-by: Swarup Ghosh <[email protected]> Signed-off-by: Swarup Ghosh <[email protected]>
@swghosh: This pull request references CM-588 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: swghosh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/testwith openshift/cert-manager-operator/master/e2e-operator #240 |
for http-01 ingress challenge based certificate issuance Signed-off-by: Swarup Ghosh <[email protected]>
feb4038
to
8b7650b
Compare
/testwith openshift/cert-manager-operator/master/e2e-operator #240 |
/hold |
Follow-up over #240,
adapts the e2e to add the
--acme-http01-solver-*
controller flags amidst existing overrides and ingress test cases.