Skip to content

CM-588: Adapt e2e with acme-http01-solver controller args #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

swghosh
Copy link
Member

@swghosh swghosh commented Jun 9, 2025

Follow-up over #240,
adapts the e2e to add the --acme-http01-solver-* controller flags amidst existing overrides and ingress test cases.

to ensure operator applies those args for cert-manager controller rollout checks

Signed-off-by: Swarup Ghosh <[email protected]>

Signed-off-by: Swarup Ghosh <[email protected]>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 9, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 9, 2025

@swghosh: This pull request references CM-588 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

Follow-up over #240,
adapts the e2e to add the --acme-http01-solver-* controller flags amidst existing overrides and ingress test cases.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 9, 2025
Copy link
Contributor

openshift-ci bot commented Jun 9, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Jun 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: swghosh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2025
@swghosh
Copy link
Member Author

swghosh commented Jun 9, 2025

/testwith openshift/cert-manager-operator/master/e2e-operator #240

for http-01 ingress challenge based certificate issuance

Signed-off-by: Swarup Ghosh <[email protected]>
@swghosh swghosh force-pushed the use-http01-solver-pod-limits branch from feb4038 to 8b7650b Compare June 9, 2025 15:34
@swghosh
Copy link
Member Author

swghosh commented Jun 9, 2025

/testwith openshift/cert-manager-operator/master/e2e-operator #240

@swghosh
Copy link
Member Author

swghosh commented Jun 10, 2025

/hold
until #240

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants