Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRPQR: wait for the job status to contain a URL after creating the job #4397

Merged

Conversation

smg247
Copy link
Member

@smg247 smg247 commented Nov 8, 2024

Not doing this can result in statuses on the PRPQR that don't have a URL to the spyglass page until after the job is complete. This has been brought on by the new Scheduling state. No URL will exist until the job is actually in Triggered, but rather than check that specifically, we can just check for the existence of a URL. The 20 second poll period is a guess that we may have to tune later.

For: https://issues.redhat.com/browse/DPTP-4174

not doing this can result in statuses on the PRPQR that don't have a URL to the spyglass page until after the job is complete.
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2024
@smg247
Copy link
Member Author

smg247 commented Nov 8, 2024

/test unit

@smg247
Copy link
Member Author

smg247 commented Nov 8, 2024

/hold due to flaky unit test, I need to figure out why that happened and/or make sure it is a one-off

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2024
@smg247
Copy link
Member Author

smg247 commented Nov 11, 2024

/test unit

@smg247
Copy link
Member Author

smg247 commented Nov 11, 2024

/hold cancel

@smg247
Copy link
Member Author

smg247 commented Nov 11, 2024

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 11, 2024
@smg247
Copy link
Member Author

smg247 commented Nov 11, 2024

/test e2e

@smg247
Copy link
Member Author

smg247 commented Nov 11, 2024

/cc @danilo-gemoli

@danilo-gemoli
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2024
Copy link
Contributor

openshift-ci bot commented Nov 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danilo-gemoli, smg247

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [danilo-gemoli,smg247]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD aaa454d and 2 for PR HEAD 513ea8e in total

@smg247
Copy link
Member Author

smg247 commented Nov 11, 2024

/override ci/prow/e2e

Copy link
Contributor

openshift-ci bot commented Nov 11, 2024

@smg247: Overrode contexts on behalf of smg247: ci/prow/e2e

In response to this:

/override ci/prow/e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@smg247
Copy link
Member Author

smg247 commented Nov 11, 2024

/override ci/prow/images

Copy link
Contributor

openshift-ci bot commented Nov 11, 2024

@smg247: Overrode contexts on behalf of smg247: ci/prow/images

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Nov 11, 2024

@smg247: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 513ea8e link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit d50dcce into openshift:master Nov 11, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants