-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PRPQR
: wait for the job status to contain a URL after creating the job
#4397
PRPQR
: wait for the job status to contain a URL after creating the job
#4397
Conversation
not doing this can result in statuses on the PRPQR that don't have a URL to the spyglass page until after the job is complete.
/test unit |
/hold due to flaky unit test, I need to figure out why that happened and/or make sure it is a one-off |
/test unit |
/hold cancel |
/label tide/merge-method-squash |
/test e2e |
/cc @danilo-gemoli |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danilo-gemoli, smg247 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/e2e |
@smg247: Overrode contexts on behalf of smg247: ci/prow/e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override ci/prow/images |
@smg247: Overrode contexts on behalf of smg247: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@smg247: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
d50dcce
into
openshift:master
Not doing this can result in statuses on the PRPQR that don't have a URL to the spyglass page until after the job is complete. This has been brought on by the new
Scheduling
state. No URL will exist until the job is actually inTriggered
, but rather than check that specifically, we can just check for the existence of a URL. The20
second poll period is a guess that we may have to tune later.For: https://issues.redhat.com/browse/DPTP-4174