Skip to content

NO-JIRA: secretannotator: Only pass clients to Reconciler, remove use of non-caching client #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

NO-JIRA: secretannotator: Only pass clients to Reconciler, remove use of non-caching client #865

wants to merge 4 commits into from

Conversation

stephenfin
Copy link
Contributor

Per $subject. This makes the clients in use a little more obvious (IMO).

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 28, 2025
@openshift-ci-robot
Copy link
Contributor

@stephenfin: This pull request explicitly references no jira issue.

In response to this:

Per $subject. This makes the clients in use a little more obvious (IMO).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from dlom and suhanime May 28, 2025 15:01
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stephenfin
Once this PR has been reviewed and has the lgtm label, please assign jstuever for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov Codecov
Copy link

codecov bot commented May 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 11.32075% with 47 lines in your changes missing coverage. Please review.

Project coverage is 46.94%. Comparing base (92e68ab) to head (737fd18).

Files with missing lines Patch % Lines
pkg/cmd/operator/cmd.go 0.00% 20 Missing ⚠️
...ator/secretannotator/secretannotator_controller.go 0.00% 6 Missing ⚠️
pkg/operator/secretannotator/aws/reconciler.go 20.00% 4 Missing ⚠️
pkg/operator/secretannotator/azure/reconciler.go 0.00% 4 Missing ⚠️
pkg/operator/secretannotator/gcp/reconciler.go 0.00% 4 Missing ⚠️
...g/operator/secretannotator/openstack/reconciler.go 20.00% 4 Missing ⚠️
pkg/operator/secretannotator/vsphere/reconciler.go 0.00% 3 Missing ⚠️
pkg/aws/actuator/actuator.go 80.00% 1 Missing ⚠️
pkg/operator/controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #865      +/-   ##
==========================================
- Coverage   46.97%   46.94%   -0.04%     
==========================================
  Files          97       96       -1     
  Lines       11910    11919       +9     
==========================================
  Hits         5595     5595              
- Misses       5697     5706       +9     
  Partials      618      618
Files with missing lines Coverage Δ
pkg/aws/actuator/actuator.go 65.52% <80.00%> (+0.07%) ⬆️
pkg/operator/controller.go 0.00% <0.00%> (ø)
pkg/operator/secretannotator/vsphere/reconciler.go 37.17% <0.00%> (ø)
pkg/operator/secretannotator/aws/reconciler.go 45.29% <20.00%> (+0.38%) ⬆️
pkg/operator/secretannotator/azure/reconciler.go 35.52% <0.00%> (ø)
pkg/operator/secretannotator/gcp/reconciler.go 45.28% <0.00%> (ø)
...g/operator/secretannotator/openstack/reconciler.go 54.01% <20.00%> (+0.39%) ⬆️
...ator/secretannotator/secretannotator_controller.go 0.00% <0.00%> (ø)
pkg/cmd/operator/cmd.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stephenfin stephenfin mentioned this pull request Jun 4, 2025
Merged
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2025
@stephenfin stephenfin force-pushed the simplify-secretannotator branch from c5f6a02 to 02ba77d Compare June 9, 2025 10:16
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2025
stephenfin added 3 commits June 9, 2025 11:34
@stephenfin
Only cache cloud config CMs
910b9f2 
This will allow us to use this caching client shortly.

Signed-off-by: Stephen Finucane <[email protected]>
@stephenfin
Remove use of non-caching client
337d507 
This was first introduced in commit 48d6ccc as a resolution to
OCPBUGS-16313 [1][2], which was itself introduced by the removal of
configmaps read access from the cluster role used by CCO. However,
non-caching clients are expensive and with the change introduced in the
previous commit, which restricted caching to specific config maps, plus
the existing role allowing access to these config maps, their use should
no longer be necessary.

[1] openshift#575
[2] https://issues.redhat.com/browse/OCPBUGS-16313

Signed-off-by: Stephen Finucane <[email protected]>
@stephenfin
manifests: Narrow allowed verbs
737fd18 
This should have been cleaned up after debugging.

Signed-off-by: Stephen Finucane <[email protected]>
@stephenfin stephenfin changed the title NO-JIRA: secretannotator: Only pass clients to Reconciler NO-JIRA: secretannotator: Only pass clients to Reconciler, remove use of non-caching client Jun 9, 2025
@stephenfin
Copy link
Contributor Author

/cc @jstuever

@openshift-ci openshift-ci bot requested a review from jstuever June 9, 2025 10:52
@stephenfin
Copy link
Contributor Author

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 10, 2025

@stephenfin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 737fd18 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn 737fd18 link true /test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlom dlom Awaiting requested review from dlom

@suhanime suhanime Awaiting requested review from suhanime

@jstuever jstuever Awaiting requested review from jstuever

Assignees
No one assigned
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephenfin @openshift-ci-robot @openshift-merge-robot