OCPBUGS-43783: openstack: Set annotation even when credentials mode is unset

[stephenfin]

Per $subject.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@stephenfin: This pull request references Jira Issue OCPBUGS-43783, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.0) matches configured target version for branch (4.20.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianping-shu

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Per $subject.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stephenfin
Once this PR has been reviewed and has the lgtm label, please assign jstuever for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@stephenfin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 46.97%. Comparing base (92e68ab) to head (ee81522).

Files with missing lines	Patch %	Lines
...g/operator/secretannotator/openstack/reconciler.go	44.44%	3 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #873      +/-   ##
==========================================
- Coverage   46.97%   46.97%   -0.01%     
==========================================
  Files          97       97              
  Lines       11910    11911       +1     
==========================================
  Hits         5595     5595              
- Misses       5697     5698       +1     
  Partials      618      618              

Files with missing lines	Coverage Δ
pkg/operator/utils/utils.go	83.13% <100.00%> (ø)
...g/operator/secretannotator/openstack/reconciler.go	53.23% <44.44%> (-0.39%)	⬇️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jianping-shu]

Test passed with the following:

1. OpenStack cluster installed successfully and healthy.
2. The annotation is added when default cco mode i.e. not configured in install-config.
   jianpingshu@jshu-mac ~ % oc get secret openstack-credentials -n kube-system -o json | jq -r ".metadata.annotations"
   {
   "cloudcredential.openshift.io/mode": "passthrough"
   }
3. Change cco mode from "" to Passthrough in cloudcredential, remove the existing annotation on root secret and the annotation is added back.
   jianpingshu@jshu-mac ~ % oc get secret openstack-credentials -n kube-system -o json | jq -r ".metadata.annotations"
   {
   "cloudcredential.openshift.io/mode": "passthrough"
   }
   This could be re-tested by configuring cco mode in install-config when OSASINFRA-3915 is ready