OPNET-600: Add UPI support to configure-ovs alternative #1702
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@cybertron: This pull request references OPNET-600 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| not run (the same thing the nmstate-configuration service would do in an | ||
| IPI scenario). | ||
|
|
||
| We likely need to move the flag file from /etc/nmstate/openshift/applied |
There was a problem hiding this comment.
I realize this is a bit vague. I'm open to suggestions on where this file should live, or if there's a better way to signal configure-ovs that the bridge configuration is already done.
|
@cybertron: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| In UPI clusters where the deployer has the ability to do arbitrary network | ||
| configuration before deployment, there may be no need for NMState to be | ||
| involved at deploy-time. Instead, the deployer can do the bridge | ||
| configuration and then touch a file to indicate that configure-ovs should |
There was a problem hiding this comment.
Not a great UX requiring the user to touch a file (via MCO?).
Maybe there is a way to tell when it is a UPI install right before nmstate executes and skip it?
We've had requests to support non-NMState methods for doing initial bridge configuration for OVNKubernetes. This updates the original enhancement to cover that use case.