-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPNODE-2877: Update cgroups enhancement proposal to support the removal of cgroupv1 #1751
OCPNODE-2877: Update cgroups enhancement proposal to support the removal of cgroupv1 #1751
Conversation
@sairameshv: This pull request references OCPNODE-2877 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
f1c6619
to
07e7975
Compare
/cc @haircommander |
07e7975
to
f615d80
Compare
f615d80
to
8324f74
Compare
/retest |
8324f74
to
28d313f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall makes sense, some questions inline
28d313f
to
a400874
Compare
a400874
to
53ea86e
Compare
53ea86e
to
827fe1c
Compare
@rphillips @haircommander Could you take a re-look at the updated changes? |
/lgtm thanks! |
- Add a CEL validation to deny the setting of `cgroupMode` to `v1` - Block the upgrades if the cluster is on cgroups v1 - Add an upgrade edge i.e. minimum 4.18 version to support seamless upgrade from 4.18 to 4.19 Signed-off-by: Sai Ramesh Vanka <[email protected]>
827fe1c
to
40761d4
Compare
@sairameshv: This pull request references OCPNODE-2877 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrunalp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@sairameshv: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Here is the updated cgroups enhancement proposal that includes the removal of cgroup v1 from the OCP clusters starting from 4.19.
Following is the summary of the updated enhancement proposal
cgroupMode
tov1
upgrade from 4.18 to 4.19
/cc @rphillips @mrunalp @deads2k @yuqi-zhang