Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPNODE-2877: Update cgroups enhancement proposal to support the removal of cgroupv1 #1751

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

sairameshv
Copy link
Member

@sairameshv sairameshv commented Feb 5, 2025

Here is the updated cgroups enhancement proposal that includes the removal of cgroup v1 from the OCP clusters starting from 4.19.

Following is the summary of the updated enhancement proposal

  • Add a CEL validation to deny the setting of cgroupMode to v1
  • Block the upgrades if the cluster is on cgroups v1
  • Add an upgrade edge i.e. minimum 4.18 version to support seamless
    upgrade from 4.18 to 4.19

/cc @rphillips @mrunalp @deads2k @yuqi-zhang

@sairameshv sairameshv changed the title Update cgroups enhancement proposal to support the removal of cgroupv1 OCPNODE-2877: Update cgroups enhancement proposal to support the removal of cgroupv1 Feb 5, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 5, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 5, 2025

@sairameshv: This pull request references OCPNODE-2877 which is a valid jira issue.

In response to this:

Here is the updated cgroups enhancement proposal that includes the removal of cgroup v1 from the OCP clusters starting from 4.19.

/cc @rphillips @mrunalp @deads2k @yuqi-zhang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sairameshv
Copy link
Member Author

/cc @haircommander

@openshift-ci openshift-ci bot requested a review from haircommander February 5, 2025 12:58
@sairameshv
Copy link
Member Author

/retest

Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall makes sense, some questions inline

@sairameshv
Copy link
Member Author

@rphillips @haircommander Could you take a re-look at the updated changes?

@haircommander
Copy link
Member

/lgtm

thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2025
- Add a CEL validation to deny the setting of `cgroupMode` to `v1`
- Block the upgrades if the cluster is on cgroups v1
- Add an upgrade edge i.e. minimum 4.18 version to support seamless
  upgrade from 4.18 to 4.19

Signed-off-by: Sai Ramesh Vanka <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 17, 2025

@sairameshv: This pull request references OCPNODE-2877 which is a valid jira issue.

In response to this:

Here is the updated cgroups enhancement proposal that includes the removal of cgroup v1 from the OCP clusters starting from 4.19.

Following is the summary of the updated enhancement proposal

  • Add a CEL validation to deny the setting of cgroupMode to v1
  • Block the upgrades if the cluster is on cgroups v1
  • Add an upgrade edge i.e. minimum 4.18 version to support seamless
    upgrade from 4.18 to 4.19

/cc @rphillips @mrunalp @deads2k @yuqi-zhang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sairameshv sairameshv requested a review from mrunalp February 17, 2025 11:49
Copy link
Contributor

openshift-ci bot commented Feb 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2025
@haircommander
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2025
Copy link
Contributor

openshift-ci bot commented Feb 20, 2025

@sairameshv: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 222d9e5 into openshift:master Feb 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants