ETCD-709: Rebase etcd 3.5.18 openshift 4.19 #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes etcd-io#18898 Signed-off-by: Thomas Jungblut <[email protected]>
[3.5] Bump golang-jwt/jwt to 4.5.1 to address GO-2024-3250
This adds the min and max TLS version support from etcd-io#13506 and etcd-io#15156 to the grpc proxy. Fixes etcd-io#13506 Signed-off-by: Thomas Jungblut <[email protected]>
[3.5] add tls min/max version to grpc proxy
Signed-off-by: KT <[email protected]>
[3.5] fix runtime error: comparing uncomparable type
Signed-off-by: Benjamin Wang <[email protected]>
…1203 [3.5] Print warning message for deprecated v2 flags if set
Signed-off-by: Anurag De <[email protected]>
[3.5] Bump go toolchain to 1.22.10
Part of etcd-io#18993 Signed-off-by: Wei Fu <[email protected]>
Signed-off-by: Benjamin Wang <[email protected]>
[3.5] Fix mixVersion test case: ensure a snapshot to be sent out
[3.5] support custom content check offline in v2store
Remediation for CVE-2024-45337. Signed-off-by: Ivan Valdes <[email protected]>
…g-org-x-crypto-to-0.32.0 [3.5] bump golang.org/x/crypto from 0.21.0 to 0.32.0
Remediation for CVE-2024-45338. Signed-off-by: Ivan Valdes <[email protected]>
Add space between ${ETCD_VER} and Path
Chery-pick commit 519a2e3 / pull
request etcd-io#19153.
Co-authored-by: sunfeilong <[email protected]>
Signed-off-by: Ivan Valdes <[email protected]>
Signed-off-by: Benjamin Wang <[email protected]>
Signed-off-by: Benjamin Wang <[email protected]>
[3.5] Fix release_notes.tpl.txt by adding a space between Docker image name and version
…g-org-x-net-to-0.34.0 [3.5] bump golang.org/x/net from 0.25.0 to 0.34.0
It's follow-up for etcd-io#19113 (comment) Signed-off-by: Wei Fu <[email protected]>
[3.5] etcdutl/etcdutl: use datadir package to build wal/snapdir
Signed-off-by: Joshua Zhang <[email protected]>
…lock-3.5 [3.5] Avoid deadlock in etcd.Close when stopping during bootstrapping
Signed-off-by: Ivan Valdes <[email protected]>
….22.11 [3.5] Bump go toolchain to 1.22.11
The tombstone could be the only one available revision in database. It happens when all historical revisions have been deleted in previous compactions. Since tombstone revision is still in database, we should restore it as valid key index. Otherwise, we lost that event. Signed-off-by: Wei Fu <[email protected]> (cherry picked from commit d8b4192) Signed-off-by: Wei Fu <[email protected]>
[3.5] mvcc: restore tombstone index if it's first revision
openshift-ci-robot
added
the
jira/valid-reference
|
@Elbehery: This pull request references ETCD-709 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload 4.19 nightly informing |
|
@Elbehery: trigger 67 job(s) of type informing for the nightly release of OCP 4.19
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/50a34280-dfeb-11ef-9a57-9d17fae6d5cd-0 |
|
/payload 4.19 nightly blocking |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Elbehery The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@Elbehery: trigger 14 job(s) of type blocking for the nightly release of OCP 4.19
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5cde0ee0-dfeb-11ef-814e-c439e530798e-0 |
openshift-ci
bot
added
the
approved
|
/assign @tjungblu |
|
/retest-required |
…tore This PR will add the notion of cluster ID into the initial cluster discovery process. This allows us to automatically archive a data directory when we detect the cluster identifier changing. The cluster identifier will only change when we are running a restore operation. The detection requires that the revision.json (created by the revision monitor sidecar) contains the cluster id. The cluster identifier is also stored in the local WAL, which is much more expensive to parse. We're going to only fallback to it when we could not get the cluster id from the revision.json for any reason. Otherwise the WAL stays untouched, no repair operations are attempted when it is found corrupted. Signed-off-by: Thomas Jungblut <[email protected]>
Konflux is replacing RH's internal build system OSBS. OSBS supported a build-time dependency injection system called "cachito". Konflux replaces this with "cachi2" which works differently. REMOTE_SOURCES no longer need to be copied into place and there is no need to source cachito's environment information (Konflux automatically rewrites the Dockerfile to source cachi2/cachi2.env before running the original RUN commands). Additionally, cachito appears to have provided go.sum dependencies whereas cachi2 requires all build-time dependencies in go.mod. Missing dependencies are added to go.mod as // indirect in this change.
force-new-cluster seems to have similar watch cache issues as the ordinary snapshot restore. This PR introduces the already existing utl logic as a separate package into the server-side code. This will only introduce a revbump flag, but under the hood implement both rev bumping and compaction markers. Signed-off-by: Thomas Jungblut <[email protected]>
This adds the min and max TLS version support from etcd-io#13506 and etcd-io#15156 to the grpc proxy. Signed-off-by: Thomas Jungblut <[email protected]>
…tcd-3.5.18-openshift-4.19
Elbehery
force-pushed
the
rebase-etcd-3.5.18-openshift-4.19
branch
from
c2a2506 to
b97cee5
Compare
|
/payload 4.19 nightly informing |
|
/payload 4.19 nightly blocking |
|
@Elbehery: trigger 67 job(s) of type informing for the nightly release of OCP 4.19
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/afc3e560-e0dd-11ef-98ac-40d0caf06851-0 |
|
@Elbehery: trigger 14 job(s) of type blocking for the nightly release of OCP 4.19
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b37be450-e0dd-11ef-8335-4f712a9af965-0 |
|
/override ci/prow/configmap-scale |
|
@Elbehery: Overrode contexts on behalf of Elbehery: ci/prow/configmap-scale In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@Elbehery: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rebases etcd 3.5.18 into openshift-4.19.
running
makelocallycc @openshift/openshift-team-etcd