Skip to content

AUTOSCALE-257: configure repository to use tools downstream #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2025
Merged

AUTOSCALE-257: configure repository to use tools downstream #5

merged 1 commit into from
Jun 11, 2025

Conversation

maxcao13
Copy link
Member

@maxcao13 maxcao13 commented Jun 7, 2025 •
edited
Loading

Commit does various things including adding OpenShift specific verify/toolchain scripts to work with downstream CI. Also adds go.mod for tools for reproducibility, and bumps the ci-operator go version to 1.24.0. Go versions are mismatched between tools and main module in order to satisfy the many tool dependencies that are dependent on minimum go1.24, but also keep the previous functionality intact for the main karpenter libraries.

Tested using this PR: openshift/release#65787 pointing to my maxcao13/karpenter:openshift-main branch on my fork.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 7, 2025 •
edited by openshift-ci bot
Loading

@maxcao13: This pull request references AUTOSCALE-257 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Commit does various things including adding OpenShift specific verify/toolchain scripts to work with downstream CI. Also adds go.mod for tools for reproducibility, and bumps the ci-operator go version to 1.24.0. Go versions are mismatched between tools and main module in order to satisfy the many tool dependencies that are dependent on minimum go1.24, but also keep the previous functionality intact for the main karpenter libraries.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jkyros and muraee June 7, 2025 00:17
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 7, 2025 •
edited by openshift-ci bot
Loading

@maxcao13: This pull request references AUTOSCALE-257 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Commit does various things including adding OpenShift specific verify/toolchain scripts to work with downstream CI. Also adds go.mod for tools for reproducibility, and bumps the ci-operator go version to 1.24.0. Go versions are mismatched between tools and main module in order to satisfy the many tool dependencies that are dependent on minimum go1.24, but also keep the previous functionality intact for the main karpenter libraries.

Tested using this PR: openshift/release#65787 pointing to my maxcao13/karpenter:openshift-main branch on my fork.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@maxcao13
Copy link
Member Author

maxcao13 commented Jun 7, 2025

Note the verify and unit tests passing:

https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/65787/rehearse-65787-pull-ci-maxcao13-karpenter-openshift-main-verify/1931121794605912064

https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/65787/rehearse-65787-pull-ci-maxcao13-karpenter-openshift-main-unit/1931121794538803200

from the debug PR: openshift/release#65787

elmiko
elmiko reviewed Jun 10, 2025
View reviewed changes
Copy link

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly makes sense to me, just a question about the vendoring.

@maxcao13
UPSTREAM: <carry>: configure repository to use tools downstream
c225a71 
Commit does various things including adding OpenShift specific verify/toolchain scripts to work with downstream CI.
Also adds go.mod for tools for reproducibility, and bumps the ci-operator go version to 1.24.0.
Go versions are mismatched between tools and main module because in order to use the new tool directive feature
but also keep the previous functionality intact for the main karpenter libraries.

Signed-off-by: Max Cao <[email protected]>
elmiko
elmiko reviewed Jun 11, 2025
View reviewed changes
Copy link

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2025
@maxcao13 maxcao13 merged commit 9ec6578 into openshift:main Jun 11, 2025
@maxcao13 maxcao13 mentioned this pull request Jun 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko elmiko left review comments

@jkyros jkyros Awaiting requested review from jkyros

@muraee muraee Awaiting requested review from muraee

Assignees

@elmiko elmiko

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxcao13 @openshift-ci-robot @elmiko