(OSD-25580) Ship Network Live Migration Metrics to Telemetry

[dakotalongRH]

Introduce new alerting for the SDN to OVN migration

What type of PR is this?

(bug/feature/cleanup/documentation)

What this PR does / why we need it?

Which Jira/Github issue(s) this PR fixes?

https://issues.redhat.com/browse/OSD-25580

Fixes #

Special notes for your reviewer:

Pre-checks (if applicable):

• Tested latest changes against a cluster

• Included documentation changes with PR

• If this is a new object that is not intended for the FedRAMP environment (if unsure, please reach out to team FedRAMP), please exclude it with:

  matchExpressions:
  - key: api.openshift.com/fedramp
    operator: NotIn
    values: ["true"]

[dakotalongRH]

/retest

[abyrne55]

Good work @dakotalongRH. In addition to my inline comments, could we add another recording rule that just exports openshift_network_operator_live_migration_condition as-is into an exported name (e.g., cluster:usage:openshift_network_operator_live_migration_condition)?

[abyrne55]

Do we know if sre:... is valid for getting this metric exported to Telemeter? The card/CMO regex would seem to indicate that only cluster:usage... metrics get this treatment, but its very possible there's other components picking up sre:... metrics that I'm not aware of

Regardless, I wouldn't name this recording rule "condition", as I think it's just recording an integer number of seconds of how long the migration is/was in_progress. Perhaps "duration"?

[dakotalongRH]

Changing to "cluster:usage:network-live-migration:*"

[abyrne55]

I'm curious what difference the == 1 makes w.r.t. how the exported metric shows up in telemeter; do we need it? My export-naming concerns from above also apply here

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dakotalongRH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• deploy/sre-prometheus/OWNERS [dakotalongRH]
• hack/OWNERS [dakotalongRH]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[abyrne55]

/label tide/merge-method-squash

[openshift-ci]

@dakotalongRH: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.