Skip to content

Conversation

@jim-minter
Copy link
Contributor

@jim-minter jim-minter commented Mar 29, 2019

restrict #pods/node to 50 as a starting point for GA

@openshift-ci-robot openshift-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 29, 2019
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 29, 2019
rotate-certificates:
- "true"
runtime-request-timeout:
- 10m
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is new, what does it do?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How long kubelet will try to GET,PUT, to docker to get stuff out. Does not include watchers (like logs).

@mjudeikis
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jim-minter, mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [jim-minter,mjudeikis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Apr 1, 2019

Codecov Report

Merging #1383 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1383   +/-   ##
=======================================
  Coverage   40.31%   40.31%           
=======================================
  Files         162      162           
  Lines       11244    11244           
=======================================
  Hits         4533     4533           
  Misses       6420     6420           
  Partials      291      291

@mjudeikis
Copy link
Contributor

/retest

@openshift-merge-robot openshift-merge-robot merged commit 76d862d into openshift:master Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants