-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding node : redhat-support-tool has been deprecated in RHEL 8 and will not be shipped in RHEL 9 onwards #84632
base: main
Are you sure you want to change the base?
Conversation
adding node : redhat-support-tool and redhat-support-lib-python have been deprecated in RHEL 8 and will not be shipped in RHEL 9 onwards
@Shubhampwrredhat: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
I have created a BUG for this issue: https://issues.redhat.com/browse/OCPBUGS-44342 |
/label peer-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small suggestions to consider; otherwise LGTM
Before sending for the merge review, please seek a QE approval.
The `redhat-support-tool` has been deprecated in RHEL 8 and will not be shipped in RHEL 9 onwards. | ||
See link:https://access.redhat.com/articles/445443[Red Hat Access: Red Hat Support Tool] for more complete information on `redhat-support-tool`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The `redhat-support-tool` has been deprecated in RHEL 8 and will not be shipped in RHEL 9 onwards. | |
See link:https://access.redhat.com/articles/445443[Red Hat Access: Red Hat Support Tool] for more complete information on `redhat-support-tool`. | |
The `redhat-support-tool` command has been deprecated in {op-system-base-full} 8.0 and will be removed in {op-system-base} 9.0 and later. | |
For more information, see link:https://access.redhat.com/articles/445443[Red Hat Access: Red Hat Support Tool]. |
- Consider using attributes for RHEL. For future referrence, see https://github.com/openshift/openshift-docs/blob/main/_attributes/common-attributes.adoc
- Use {op-system-base-full} for the first occurrence in the module, otherwise you can use {op-system-base}
- Since you are using an article (
the
) consider mentioning what kindredhat-support-tool
is, for example, "tool" or "command". - Versions are described as --
8.0
,9.0
,7.0
, instead of8
,9
- "For more information, see....." You can follow this format for links.
adding node : redhat-support-tool has been deprecated in RHEL 8 and will not be shipped in RHEL 9 onwards
Version(s):
4.13
4.14
4.15
4.16
4.17
Issue:
https://issues.redhat.com/browse/OCPBUGS-44342
Link to docs preview:
https://84632--ocpdocs-pr.netlify.app/openshift-enterprise/latest/support/gathering-cluster-data.html#support-providing-diagnostic-data-to-red-hat_gathering-cluster-data
QE review:
Additional information: