Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise-4.16] OCPBUG 19873: Created Cri-O default capabilities section #84687

Open
wants to merge 1 commit into
base: enterprise-4.16
Choose a base branch
from
Open

[Enterprise-4.16] OCPBUG 19873: Created Cri-O default capabilities section #84687

wants to merge 1 commit into from
+132 −1

Conversation

subhtk
Copy link
Contributor

@subhtk subhtk commented Nov 8, 2024 •
edited
Loading

#78951

Cherry picked from PR from commit ID

Version(s): 4.16

Issue: https://issues.redhat.com/browse/OCPBUGS-19873

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 8, 2024
@ocpdocs-previewbot
Copy link

🤖 Fri Nov 08 17:40:51 - Prow CI generated the docs preview:

https://84687--ocpdocs-pr.netlify.app/
https://84687--ocpdocs-pr.netlify.app/openshift-enterprise/latest/machine_configuration/index.html

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 8, 2024

@subhtk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@subhtk
Copy link
Contributor Author

subhtk commented Nov 8, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 8, 2024
@adellape adellape added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Nov 8, 2024
@adellape adellape self-assigned this Nov 8, 2024
@adellape adellape removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Nov 8, 2024
@adellape
Copy link
Contributor

adellape commented Nov 8, 2024

@subhtk Apologies if I'm missing some context, but I don't see a peer-review-done on here, and the referenced PRs that this cherrypick is related to are fairly old. I feel like this should go through a new round of peer-review-needed first before merge. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adellape adellape

Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@subhtk @ocpdocs-previewbot @adellape