Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOSTEDCP-1971: hypershift: add HO upgrade test #58638

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

HOSTEDCP-1971: hypershift: add HO upgrade test #58638

wants to merge 2 commits into from
+454 −35

Conversation

devguyio
Copy link
Contributor

@devguyio devguyio commented Nov 8, 2024 •
edited
Loading

Description

Add a pre-submit test which runs the hypershift operator upgrade test.

This PR adds the following to the step-registry

  1. hypershift-install-initial-ref

    • Installs HyperShift Operator using the initial integration stream

  2. hypershift-aws-run-e2e-external-upgrade-setup-ref

    • Runs the e2e tests binary with the upgrade.run-setup flag to trigger the setup phase of the upgrade test.

  3. hypershift-aws-run-e2e-external-upgrade-test-ref

    • Runs the e2e tests binary with the upgrade.run-tests flag to trigger the upgrade test.

  4. hypershift-aws-upgrade-test-setup-chain

    A chain to prepare the the upgrade test workflow.
    1. Create the management cluster.
    2. Install HO initial release using hypershift-install-initial-ref
    3. Trigger the upgrade-test setup using hypershift-aws-run-e2e-external-upgrade-setup-ref

  5. hypershift-aws-upgrade-test-run-chain

    A chain to run the upgrade test.
    1. Upgrade the HO to the version under test.
    2. Trigger the upgrade test using hypershift-aws-run-e2e-external-upgrade-test-ref

  6. hypershift-aws-upgrade-test-workflow

    This is the upgrade tests workflow. It roughly does the following
    1. pre: upgrade tests setup chain hypershift-aws-upgrade-test-setup-chain
    2. test: upgrade tests run chain hypershift-aws-upgrade-test-run-chain
    3. post: destroy and cleanup

@devguyio
Add upgrade test to hypershift
e98bc1f 
Signed-off-by: Ahmed Abdalla <[email protected]>
@devguyio
Run "make update"
064f2af 
Signed-off-by: Ahmed Abdalla <[email protected]>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 8, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 8, 2024 •
edited by openshift-ci bot
Loading

@devguyio: This pull request references HOSTEDCP-1971 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Description

Add a pre-submit test which runs the hypershift operator upgrade test.

This PR adds the following to the step-registry

  1. hypershift-install-initial-ref

    • Installs HyperShift Operator using the initial integration stream

  2. hypershift-aws-run-e2e-external-upgrade-setup-ref

    • Runs the e2e tests binary with the upgrade.run-setup flag to trigger the setup phase of the upgrade test.

  3. hypershift-aws-run-e2e-external-upgrade-test-ref

    • Runs the e2e tests binary with the upgrade.run-tests flag to trigger the upgrade test.

  4. hypershift-aws-upgrade-test-setup-chain

    A chain to prepare the the upgrade test workflow.
    1. Create the management cluster.
    2. Install HO initial release using hypershift-install-initial-ref
    3. Trigger the upgrade-test setup using hypershift-aws-run-e2e-external-upgrade-setup-ref

  5. hypershift-aws-upgrade-test-run-chain

    A chain to run the upgrade test.
    1. Upgrade the HO to the version under test.
    2. Trigger the upgrade test using hypershift-aws-run-e2e-external-upgrade-test-ref

  6. hypershift-aws-upgrade-test-workflow

    This is the upgrade tests workflow. It roughly does the following
    1. pre: upgrade tests setup chain hypershift-aws-upgrade-test-setup-chain
    2. test: upgrade tests run chain hypershift-aws-upgrade-test-run-chain
    3. post: destroy and cleanup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 8, 2024 •
edited by openshift-ci bot
Loading

@devguyio: This pull request references HOSTEDCP-1971 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Description

Add a pre-submit test which runs the hypershift operator upgrade test.

This PR adds the following to the step-registry

  1. hypershift-install-initial-ref

    • Installs HyperShift Operator using the initial integration stream

  2. hypershift-aws-run-e2e-external-upgrade-setup-ref

    • Runs the e2e tests binary with the upgrade.run-setup flag to trigger the setup phase of the upgrade test.

  3. hypershift-aws-run-e2e-external-upgrade-test-ref

    • Runs the e2e tests binary with the upgrade.run-tests flag to trigger the upgrade test.

  4. hypershift-aws-upgrade-test-setup-chain

    A chain to prepare the the upgrade test workflow.
    1. Create the management cluster.
    2. Install HO initial release using hypershift-install-initial-ref
    3. Trigger the upgrade-test setup using hypershift-aws-run-e2e-external-upgrade-setup-ref

  5. hypershift-aws-upgrade-test-run-chain

    A chain to run the upgrade test.
    1. Upgrade the HO to the version under test.
    2. Trigger the upgrade test using hypershift-aws-run-e2e-external-upgrade-test-ref

  6. hypershift-aws-upgrade-test-workflow

    This is the upgrade tests workflow. It roughly does the following
    1. pre: upgrade tests setup chain hypershift-aws-upgrade-test-setup-chain
    2. test: upgrade tests run chain hypershift-aws-upgrade-test-run-chain
    3. post: destroy and cleanup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: devguyio
Once this PR has been reviewed and has the lgtm label, please assign bryan-cox for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@devguyio: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-hypershift-main-e2e-upgrade-tests-aws openshift/hypershift presubmit Presubmit changed
pull-ci-openshift-hypershift-main-e2e-aks openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-aws openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-aws-4-17 openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-aws-metrics openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-azure-aks-ovn-conformance openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-conformance openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-kubevirt-aws-ovn openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-kubevirt-aws-ovn-reduced openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-kubevirt-azure-ovn openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-kubevirt-metal-conformance openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-openstack openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-openstack-conformance openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-openstack-csi-cinder openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-openstack-csi-manila openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-e2e-openstack-nfv openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-images openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-okd-scos-images openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-security openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-unit openshift/hypershift presubmit Ci-operator config changed
pull-ci-openshift-hypershift-main-verify openshift/hypershift presubmit Ci-operator config changed
periodic-ci-openshift-hypershift-main-equinix-cleanup-cluster-equinix-ocp-hcp N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 8, 2024

@devguyio: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/step-registry-shellcheck 064f2af link true /test step-registry-shellcheck

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryan-cox bryan-cox Awaiting requested review from bryan-cox

@csrwng csrwng Awaiting requested review from csrwng

Assignees
No one assigned
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devguyio @openshift-ci-robot