aws only public subnets coverage #62226
Conversation
|
@jianlinliu, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
jianlinliu
force-pushed
the
publicsubnets
branch
3 times, most recently
from
b237ec8 to
ba8158a
Compare
|
/pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.18-aws-ipi-byo-subnets-only-public-arm-f14 |
|
@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
jianlinliu
force-pushed
the
publicsubnets
branch
from
ba8158a to
facc2a7
Compare
|
/pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.18-aws-ipi-byo-subnets-only-public-arm-f14 |
|
@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
jianlinliu
force-pushed
the
publicsubnets
branch
from
facc2a7 to
5cfc484
Compare
|
/pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.18-aws-ipi-byo-subnets-only-public-arm-f14 |
|
@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
jianlinliu
force-pushed
the
publicsubnets
branch
from
5cfc484 to
7ebcd8b
Compare
|
/pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.18-aws-ipi-byo-subnets-only-public-arm-f14 |
|
@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
jianlinliu
force-pushed
the
publicsubnets
branch
from
7ebcd8b to
ff69bee
Compare
|
/pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.18-aws-ipi-byo-subnets-only-public-arm-f14 |
|
@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.19-aws-ipi-shared-phz-sts-f14 |
|
@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-aws-ipi-workers-marketplace-public-subnets-mini-perm-f7 |
|
@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
rehearse testing jobs get passed. When cc @yunjiang29 to review. |
jianlinliu
force-pushed
the
publicsubnets
branch
2 times, most recently
from
2ec5a2f to
dcd3744
Compare
|
/pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.18-aws-ipi-byo-subnets-only-public-arm-f14 |
|
@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
jianlinliu
force-pushed
the
publicsubnets
branch
from
b994771 to
181b3da
Compare
|
@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@jianlinliu: job(s): periodic-ci-openshift-verification-tests-master-installation-nightly-4.18-aws-ipi-byo-subnets-only-public-arm-f14 either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.18-aws-ipi-byo-subnets-only-public-mini-perm-arm-f14 |
|
@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@jianlinliu: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/assign @yunjiang29 |
| private_subnet_ids=$(yq-go r -j ${SHARED_DIR}/private_subnet_ids | jq -r '[ . | join(" ") ] | @csv' | sed "s/\"//g") | ||
|
|
||
| if [[ "${OPENSHIFT_INSTALL_AWS_PUBLIC_ONLY}" == "true" ]]; then | ||
| private_subnet_ids=$(yq-go r -j ${SHARED_DIR}/public_subnet_ids | jq -r '[ . | join(" ") ] | @csv' | sed "s/\"//g") |
There was a problem hiding this comment.
To avoid confusion, I'd suggest replacing private_subnet_ids with subnet_ids
| @@ -0,0 +1,9 @@ | |||
| workflow: | |||
| as: cucushift-installer-rehearse-aws-ipi-workers-marketplace-byo-subnets | |||
There was a problem hiding this comment.
Is this workflow used in the jobs?
There was a problem hiding this comment.
I was planing to use this install workflow to cover marketplace ci jobs, in the last minutes, I decided to do that later, just developed the new install workflow here for later reference.
| - name: OPENSHIFT_INSTALL_AWS_PUBLIC_ONLY | ||
| default: "" | ||
| documentation: |- | ||
| Whether to use only public subnets for AWS. Implies no NAT Gateways. |
There was a problem hiding this comment.
Suggest to add a note that indicates OPENSHIFT_INSTALL_AWS_PUBLIC_ONLY will be used by create permissions-policy validation.
|
Additional node, once
This works well on current PR/jobs, but I'm not sure if it will cause other potential issues in other job configs with |
So far, there is no many other jobs enabled |
jianlinliu
force-pushed
the
publicsubnets
branch
from
10ddb43 to
c342fe2
Compare
|
/pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.18-aws-ipi-byo-subnets-only-public-mini-perm-arm-f14 |
|
@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-verification-tests-master-installation-nightly-4.19-aws-ipi-shared-phz-sts-f14 |
|
@jianlinliu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
jianlinliu
force-pushed
the
publicsubnets
branch
from
c342fe2 to
6cb1b96
Compare
|
[REHEARSALNOTIFIER]
A total of 9664 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/lgtm |
|
@yunjiang29: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
added
the
rehearsals-ack
|
@liangxia please review and approve, thanks |
@jianlinliu What's the first version that we start to support this ? My team has a card for this and we'd like to apply it to our infrastructures, too. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jianlinliu, liangxia, yunjiang29 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
From the existing ci jobs to cover the option, sounds it starts from 4.15. After talked with bear, sounds it is not enough to meet your team's requirement, so there is a followup user story. |
Installer supports
OPENSHIFT_INSTALL_AWS_PUBLIC_ONLY, once it enabled, that means the vpc would be NAT-less, installer would only depends on public subnets. The feature can help save budget for nat gateway cost.