Skip to content

OCPQE-27646: addconnectedlabel #65772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025

Conversation

huali9
Copy link
Contributor

@huali9 huali9 commented Jun 6, 2025

connected-only cases cannot run in disconnected cluster, so add filter @sunzhaohua2 @miyadav @shellyyang1989 PTAL, thanks

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 6, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 6, 2025

@huali9: This pull request references OCPQE-27646 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

connected-only cases cannot run in disconnected cluster, so add filter @sunzhaohua2 @miyadav @shellyyang1989 PTAL, thanks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from lihongan and Xia-Zhao-rh June 6, 2025 09:53
@huali9 huali9 force-pushed the addconnectedlabel branch from 5723546 to 773d39b Compare June 6, 2025 10:14
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@huali9: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-openshift-tests-private-release-4.18-arm64-nightly-aws-ipi-dis-priv-sts-ep-min-perm-f28-longduration-cloud N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.19-amd64-nightly-aws-c2s-ipi-disc-priv-fips-f28-tp-longduration-cloud N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.15-amd64-nightly-aws-c2s-ipi-disc-priv-fips-f60-longduration-cloud N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-aws-c2s-ipi-disc-priv-fips-f28-longduration-cloud N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-aws-c2s-ipi-disc-priv-fips-f28-tp-longduration-cloud N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.14-arm64-nightly-gcp-ipi-disc-priv-oidc-f60-longduration-cloud N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-azure-ipi-disc-oidc-f28-longduration-cloud N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.14-arm64-nightly-azure-ipi-disc-oidc-f60-longduration-cloud N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.15-arm64-nightly-aws-ipi-dis-priv-sts-ep-min-perm-f60-longduration-cloud N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@sunzhaohua2
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2025
@huali9
Copy link
Contributor Author

huali9 commented Jun 9, 2025

/assign @liangxia

Copy link
Contributor

openshift-ci bot commented Jun 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huali9, liangxia, sunzhaohua2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2025
@huali9
Copy link
Contributor Author

huali9 commented Jun 9, 2025

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@huali9: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 9, 2025
Copy link
Contributor

openshift-ci bot commented Jun 9, 2025

@huali9: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit a0aea84 into openshift:master Jun 9, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants