-
Notifications
You must be signed in to change notification settings - Fork 387
rework of pin config page #1773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MaxineMuster
wants to merge
16
commits into
openshwprojects:main
Choose a base branch
from
MaxineMuster:rolerework
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c/rolesNchannels.h". This will be imported by all files using pin-roles and its attributes (i.e. number of channels) while "old" information is commented out. The input file also includes information on use of channels ("T" for temperature, "H" for humidity ...). If you set it will include this information to pin config page. Size of resulting image is slightly smaller due to som optimizations in JS code. If you include the additional information, it will be approx 350bytes larger
…arning (or even errors with -Werror) Simulators not working, need to figure out how to invoke awk-script there ...
for testing: Enable extended channels on W800
…n new header file src/rolesNchannels.h Add some descriptions for LED drivers and display
…to (generated) src/rolesNchannels.h
….c to avoid duplicate commands Qick and dirty fix for getcommands.js modifying code - by disabling writes adding "&& false" as condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a single text file to combine all information about roles and channels.
Actually we have information in this files:
new_pins.h
new_pins.c
new_http.c
... and maybe in http_fns.c if we want to add some information about channel usage.
This approach will put all in a file with this entries
So, here's some kind of documentation:
Changed also
Combining the two "IR" driver lines in one in "drv_main.c" (else getcommands.js will complain about duplicate descriptions - alternative the second command could simply be without comment)
A "quick and dirty" solution for getcommands.js removing needed lines in code - simply not allowing to write to this files.