Refactor static variables in OpenSim::IO#3948
Merged
nickbianco merged 2 commits intomainfrom Oct 23, 2024
Merged
Conversation
nickbianco
approved these changes
Oct 23, 2024
Member
nickbianco
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @adamkewley)
Member
|
Thanks @adamkewley! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor cleanup to #3943
IOinto the cpp file as static-linkage variables_localestatic variable and instead just callsstd::locale::classic()(no comments etc. were written to justify why it's worth caching - probably doesn't matter)The reason I'm throwing this in separately is because it's much less tedious than slowly back-and-forthing on a separate PR. I'll merge this once it's through CI.
This change is