Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor static variables in OpenSim::IO #3948

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

adamkewley
Copy link
Contributor

@adamkewley adamkewley commented Oct 23, 2024

Minor cleanup to #3943

  • Moves static variables in IO into the cpp file as static-linkage variables
  • Removes _locale static variable and instead just calls std::locale::classic() (no comments etc. were written to justify why it's worth caching - probably doesn't matter)
  • Adds missing CHANGELOG.md entry for Improved String to Decimal parsing #3943

The reason I'm throwing this in separately is because it's much less tedious than slowly back-and-forthing on a separate PR. I'll merge this once it's through CI.


This change is Reviewable

Copy link
Member

@nickbianco nickbianco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @adamkewley)

@nickbianco nickbianco merged commit bef3264 into main Oct 23, 2024
12 checks passed
@nickbianco nickbianco deleted the refactor_cleanup-3943 branch October 23, 2024 16:44
@nickbianco
Copy link
Member

Thanks @adamkewley!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants