Add OPENSIM_DISABLE_STATIC_TYPE_REGISTRATION cmake option #4012
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch I've been applying downstream in opensim-creator that I figured might be useful for opensim-core.
This adds an
OPENSIM_DISABLE_STATIC_TYPE_REGISTRATION
cmakeoption
that can be toggledON
to build OpenSim without the static-init-time instantiator classes.The motivation for doing this is:
osimActuators.dll
depends onosimCommon.dll
, so the dynamic loader just happens to load one before the other - this may fail if they are merged into one binary. It may also fail if (e.g.) the log is statically initialized after a static registration function that writes to the log (a segfault I encountered with OpenSim Creator).Brief summary of changes
OPENSIM_DISABLE_STATIC_TYPE_REGISTRATION
toCMakeLists.txt
Testing I've completed
Looking for feedback on...
CHANGELOG.md (choose one)
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)