Add docopt as a vendor
#4082
Merged
Add docopt as a vendor
#4082
+1,955
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I assume no actual change to docopt files (they are not in repo) so LGTM |
|
The only changes I made to the source were to remove compiler definitions that I didn't think we would use. These were options to build Pushed one more commit to remove some |
|
CI is still passing after the last commit (except for the expected failure on Arm64). Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #4061
Brief summary of changes
Adds the latest commit of the C++ port of docopt as a vendor to OpenSim.
Testing I've completed
docoptis indirectly tested viatestCommandLineInterface.cpp. I haven't performed any manual testing (yet, I will try soon). We could potentially move some of the tests from the docopt repo over.Looking for feedback on...
I stripped out the code to build
docoptas a header-only library. If we think that might be useful as an option later, I could add it back in.CHANGELOG.md (choose one)
This change is