Tibia edits #74
Merged
Tibia edits #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Screen Grab of Gait2392 with the updated (names corrected) tibia_r.vtp and tibia_l.vtp
|
|
@tkuchida, could you have a quick look to give me the 👍 then I will merge. |
|
Sorry, I didn't get to it last night. |
|
no problem! Thanks a bunch :) |
tkuchida
requested changes
May 25, 2018
There was a problem hiding this comment.
The "Geometry Path" preference doesn't seem to be working properly, so I reviewed by copying the Geometry directory into the same directory as each model. Of the 42 models containing tibias, 26 have been fixed and 16 are still wrong.
Fixed:
- Models\Gait10dof18musc\gait10dof18musc.osim
- Models\Gait10dof18musc\subject01.osim
- Models\Gait10dof18musc\subject01_metabolics.osim
- Models\Gait10dof18musc\subject01_metabolics_path_actuator.osim
- Models\Gait10dof18musc\subject01_metabolics_path_spring.osim
- Models\Gait10dof18musc\subject01_metabolics_spring.osim
- Models\Gait2354_Simbody\gait2354_simbody.osim
- Models\Gait2354_Simbody\subject01_simbody.osim
- Models\Gait2392_Simbody\gait2392_millard2012muscle.osim
- Models\Gait2392_Simbody\gait2392_thelen2003muscle.osim
- Models\Gait2392_Simbody\subject01.osim
- Models\Gait2392_Simbody\subject01_adjusted.osim
- Models\Gait2392_Simbody\subject01_simbody_adjusted.osim
- Models\Hamner\FullBodyModel_Hamner2010_v2_0.osim
- Models\Leg6Dof9Musc\leg6dof9musc.osim
- Models\RajagopalModel\Rajagopal2015.osim
- Models\SoccerKick\SoccerKickingModel.osim
- Pipelines\Hamner\FullBodyModel_Hamner2010_v2_0.osim
- Pipelines\Hamner\outputReference\subject02_registered.osim
- Pipelines\Hamner\outputReference\subject02_RRA_Adjusted.osim
- Pipelines\Hamner\outputReference\subject02_scaled.osim
- Pipelines\Rajagopal\outputReference\subject01_registered.osim
- Pipelines\Rajagopal\outputReference\subject01_RRA_Adjusted.osim
- Pipelines\Rajagopal\outputReference\subject01_scaled.osim
- Tutorials\Strength_of_Simulation\Stance\Reference\leg6dof9musc_added_mass.osim
- Tutorials\Strength_of_Simulation\Stance\Reference\RRA\leg6dof9musc_adjusted.osim
Backwards:
- Models\Jumper\DynamicJumperModel.osim
- Models\ToyLanding\ToyLandingModel.osim
- Models\ToyLanding\ToyLandingModel_activeAFO.osim
- Models\ToyLanding\ToyLandingModel_AFO.osim
- Pipelines\Gait10dof18musc\OutputReference\gait10dof18musc.osim
- Pipelines\Gait10dof18musc\OutputReference\subject01.osim
- Pipelines\Gait10dof18musc\OutputReference\CMC\subject01_metabolics.osim
- Pipelines\Gait10dof18musc\OutputReference\CMC\subject01_metabolics_path_actuator.osim
- Pipelines\Gait10dof18musc\OutputReference\CMC\subject01_metabolics_path_spring.osim
- Pipelines\Gait10dof18musc\OutputReference\CMC\subject01_metabolics_spring.osim
- Pipelines\Gait2354_Simbody\OutputReference\subject01_scaledOnly.osim
- Pipelines\Gait2354_Simbody\OutputReference\subject01_simbody.osim
- Pipelines\Gait2354_Simbody\OutputReference\subject01_simbody_adjusted.osim
- Pipelines\Gait2392_Simbody\OutputReference\subject01_simbody.osim
- Pipelines\Gait2392_Simbody\OutputReference\subject01_simbody_adjusted.osim
- Tutorials\Estimating_Joint_Reaction_Loads\subject01_simbody_adjusted_StaticOp.osim
|
Ready for re-review? |
|
Yes, please. The models you identified as having backwards tibias have been addressed. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(i) Deleted extraneous tibia geometry
(ii) Corrected the left and right tibia geometry
(iii) Updated gait models to use correct geometry