Skip to content

Add warning+link to rules for responding to jobs #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025

Conversation

Ian2020
Copy link
Contributor

@Ian2020 Ian2020 commented Jun 5, 2025

Fix for opensourcedesign/opensourcedesign.github.io#459 - added warning text:

Please don’t use generic copy-pasted responses, they can get you banned. See our [guidelines](https://discourse.opensourcedesign.net/t/guidelines-on-posting-and-responding-to-jobs/3416).

Looks like this:

Screenshot From 2025-06-05 16-09-26

(ignore the black/missing discourse widget, it won't load under my dev environment)

@Erioldoesdesign
Copy link
Member

hey there @Ian2020 thank you so much for this PR! 😄

As far as I can tell, this would add the warning text to the end of each individual job post page correct?

If we're not using the footer div for anything else it does make sense to use it for something useful like this - but i'll tag some of the folks who do more regular CSS and coding to review too @SaptakS and @AnXh3L0

Copy link
Contributor

@SaptakS SaptakS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I do agree with @Erioldoesdesign that I don't think we need to have a <footer> element for this, since I don't think that is semantically correct. If you could update the PR to remove the <footer> element and just have the <p> tag, I think this would be ready for merging.

Comment on lines 64 to 67
<footer>
<p>Please don’t use generic copy-pasted responses, they can get you banned.
See our <a href="https://discourse.opensourcedesign.net/t/guidelines-on-posting-and-responding-to-jobs/3416">guidelines</a>.</p>
</footer>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<footer>
<p>Please don’t use generic copy-pasted responses, they can get you banned.
See our <a href="https://discourse.opensourcedesign.net/t/guidelines-on-posting-and-responding-to-jobs/3416">guidelines</a>.</p>
</footer>
<p>Please don’t use generic copy-pasted responses, they can get you banned.
See our <a href="https://discourse.opensourcedesign.net/t/guidelines-on-posting-and-responding-to-jobs/3416">guidelines</a>.</p>

I don't think footer is the correct semantic element for this:

  • This doesn't seem like a footer content
  • The page already has another footer element, and it's not a good practise to have multiple footers in a page, unless inside another semantic element that needs it.

I think it can should just be a <p> tag.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, that's done! I should have just clicked commit suggestion above but did it with a local change and a force push before I remembered about Githubs web ui 😆

Copy link
Member

@Erioldoesdesign Erioldoesdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good now!

@Erioldoesdesign Erioldoesdesign requested a review from SaptakS June 25, 2025 09:29
@SaptakS SaptakS merged commit e04c6ff into opensourcedesign:master Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants