Dark theme for opensourcediversity#118
Open
siddhanth339 wants to merge 3 commits intoopensourcediversity:mainfrom
Open
Dark theme for opensourcediversity#118siddhanth339 wants to merge 3 commits intoopensourcediversity:mainfrom
siddhanth339 wants to merge 3 commits intoopensourcediversity:mainfrom
Conversation
Author
|
Please review my PR and let me know if any changes are to be made. |
Member
|
Hi @siddhanth339, good stuff! :) Here’s some points:
What do you think? :) |
Author
|
Good idea! I am working on it and will make a commit soon. Thanks for your time! |
Author
|
@jancborchardt please review my latest commit 1f42523
|
Author
|
@jancborchardt any updates? |
Member
jancborchardt
left a comment
There was a problem hiding this comment.
@siddhanth339 nice! Some feedback:
- Removing the color completely seems a bit harsh, I would say the top part works nice in the green too? And the dividers would be nice with the dash of color as well. What do you think?
- Can you check the conflicts with current main branch and resolve them? A lot of this might be because of the tabs to spaces conversion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A glimpse of the dark theme:
Also, some links were unnecessary so I have fixed them.