Skip to content

add cifmw_snr_nhc role for SNR and NHC deployment #3062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2025
Merged

add cifmw_snr_nhc role for SNR and NHC deployment #3062

merged 1 commit into from
Jul 24, 2025
+1,675 −1

Conversation

antonioromito
Copy link
Contributor

This role automates the deployment and verification of the Self Node Remediation (SNR) and Node Health Check (NHC) components on OpenShift clusters.

Included features:

  • Creation of required namespaces and OperatorGroups
  • Installation of SNR and NHC operators via Subscriptions
  • Verification of CRs like SelfNodeRemediationTemplate, Config, and NodeHealthCheck
  • Full lifecycle handling including status checks and readiness validation

@antonioromito antonioromito requested a review from a team as a code owner June 11, 2025 07:37
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 11, 2025

Hi @antonioromito. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/28e6e419975b4293b59160e7f580a8b5

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 45m 17s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 10m 25s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 30m 31s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 55s
❌ cifmw-pod-pre-commit FAILURE in 8m 05s
✔️ build-push-container-cifmw-client SUCCESS in 22m 11s

@antonioromito
Copy link
Contributor Author

recheck

@fultonj fultonj self-requested a review June 11, 2025 12:14
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d9f73db58ebe46f68ed9b32883b058ff

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 48m 53s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 13m 44s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 33m 16s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 52s
❌ cifmw-pod-pre-commit FAILURE in 8m 20s
✔️ build-push-container-cifmw-client SUCCESS in 17m 46s

@antonioromito
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/495aefee19b848c6a16cb286afa75542

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 28m 57s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 13m 27s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 22m 23s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 56s
❌ cifmw-pod-pre-commit FAILURE in 7m 52s
✔️ build-push-container-cifmw-client SUCCESS in 18m 30s

@antonioromito
Copy link
Contributor Author

recheck

fultonj
fultonj reviewed Jun 13, 2025
View reviewed changes
Copy link
Contributor

@fultonj fultonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and shouldn't break anything as it's a new role not yet called.

Please rebase and fix the spelling:

https://github.com/openstack-k8s-operators/ci-framework/actions/runs/15608572325/job/44031850263?pr=3062

@antonioromito antonioromito requested a review from a team as a code owner June 13, 2025 13:17
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/97637ecd14984d9589a3d8081e39c547

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 40m 26s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 11m 43s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 24m 47s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 12s
❌ cifmw-pod-pre-commit FAILURE in 7m 42s
✔️ build-push-container-cifmw-client SUCCESS in 20m 27s

@antonioromito antonioromito force-pushed the add-snr-nhc-role branch 8 times, most recently from 66e3852 to d168b97 Compare July 23, 2025 13:05
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/77a6782e513b4cb68c5398acc08a4a9d

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 51m 12s
❌ podified-multinode-edpm-deployment-crc FAILURE in 29m 42s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 37m 39s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 41s
❌ cifmw-pod-pre-commit FAILURE in 7m 47s
✔️ build-push-container-cifmw-client SUCCESS in 16m 09s

@danpawlik
Copy link
Contributor

hey, could you just run: make check_zuul_files and add generated files?
Thanks

danpawlik
danpawlik reviewed Jul 24, 2025
View reviewed changes
danpawlik
danpawlik reviewed Jul 24, 2025
View reviewed changes
danpawlik
danpawlik reviewed Jul 24, 2025
View reviewed changes
danpawlik
danpawlik reviewed Jul 24, 2025
View reviewed changes
@antonioromito
Add cifmw_snr_nhc role for SNR and NHC deployment
a77677a 
This role automates the deployment and verification of Self Node Remediation
(SNR) and Node Health Check (NHC) components on OpenShift clusters. Includes
namespace creation, operator installation, CR verification, and comprehensive
molecule testing framework.
evallesp
evallesp approved these changes Jul 24, 2025
View reviewed changes
Copy link
Contributor

@evallesp evallesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evallesp evallesp merged commit a02aab5 into openstack-k8s-operators:main Jul 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fultonj fultonj fultonj left review comments

@danpawlik danpawlik danpawlik approved these changes

@evallesp evallesp evallesp approved these changes

@bshewale bshewale bshewale approved these changes

Assignees
No one assigned
Labels
ok-to-test Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@antonioromito @danpawlik @evallesp @fultonj @bshewale @openshift-merge-robot