Skip to content

Consolidate config generation #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bshephar
Copy link
Contributor

@bshephar bshephar commented May 4, 2025

We currently render config-data for each of the controllers. This is largely unnecessary, we can use a single heat-config-data for each of the deployments. If absolutely required, we could allow for it to differ for the heat-engine deployment.

Copy link
Contributor

openshift-ci bot commented May 4, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented May 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 4, 2025
@bshephar bshephar force-pushed the consolidate-config branch from b944f24 to 99318b1 Compare May 4, 2025 05:31
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7e25d9d0093743eca3f9893b589e88f4

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 50m 19s
heat-operator-tempest-multinode FAILURE in 1h 30m 50s

We currently render config-data for each of the controllers.
This is largely unnecessary, we can use a single heat-config-data for each
of the deployments. If absolutely required, we could allow for it to differ
for the heat-engine deployment.

Signed-off-by: Brendan Shephard <[email protected]>
@bshephar bshephar force-pushed the consolidate-config branch from 99318b1 to d2bad44 Compare May 4, 2025 08:20
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1fadd9ea2b3c4c99aa7485433a38c68f

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 47m 53s
heat-operator-tempest-multinode FAILURE in 1h 29m 53s

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants