cache root pw in file outside of mounted volumes#388
Merged
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom Jan 26, 2026
Merged
cache root pw in file outside of mounted volumes#388openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
dciabrin
requested changes
Dec 11, 2025
Contributor
Author
|
/retest |
zzzeek
force-pushed
the
move_mycnf
branch
3 times, most recently
from
1d2aa3f to
8380a7f
Compare
Contributor
Author
|
the job passed. not sure if it was the job or the code, but this version of the code should be the most robust about making sure the /var/local/my.cnf directory exists and that galera.cnf will not error out due to missing directory / file |
Contributor
|
/lgtm |
Don't write root pw in /var/lib/mysql which is volume mounted. Also, instead of using /etc or /etc/my.cnf.d, we dont want a mysql-owned writable file in /etc which is also considered to be server configuration so since we don't actually need mariadb tools to find this file, instead write to an arbitrary file in a non-mounted directory like /var/local/mysql_pw_cache.cnf.
Contributor
|
/lgtm |
|
/approve |
dciabrin
approved these changes
Jan 26, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dciabrin, lmiccini, zzzeek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 4275b42
into
openstack-k8s-operators:main
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't write root pw in /var/lib/mysql which is volume mounted. Also, instead of using /etc or /etc/my.cnf.d, we dont want a mysql-owned writable file in /etc which is also considered to be server configuration so
since we don't actually need mariadb tools to find this file, instead write to an arbitrary file in a non-mounted directory like /var/local/mysql_pw_cache.cnf.