-
Notifications
You must be signed in to change notification settings - Fork 0
Show student's selected answer in ExercisePreview component #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There are some things here that need to be regression tested:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks reasonable to me, but I'm not familiar with the issues you're addressing. I added Josiah as a reviewer; if you need my approval later, I'll do that.
@Dantemss The props are a bit arcane but I thought we did have a way to show correct-but-not-selected bubbles if the answer_id didn't match the correct_answer_id: ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, but as you mentioned will need some regression testing rendering inside assessments with real data.
@jivey there was code trying to set styles to invert/not invert the correct answer bubble already, but then the styles in https://github.com/openstax/assessment-components/pull/99/files#diff-a4976d2d79d094466a881e76ee36ad5b4e25305bef76673a0b7f6046099b85adL92 would override everything |
https://openstax.atlassian.net/browse/CORE-933