Skip to content

Show student's selected answer in ExercisePreview component #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 18, 2025

Conversation

Dantemss
Copy link
Member

@Dantemss Dantemss self-assigned this Jul 14, 2025
@Dantemss
Copy link
Member Author

There are some things here that need to be regression tested:

  • We used to print an nbsp when answers were not being labeled (not in ExercisePreview), I turned that off
  • Correct answers were always filled bubbles, now they can be unfilled if they were not selected

@Dantemss Dantemss marked this pull request as ready for review July 15, 2025 14:34
@Dantemss Dantemss requested a review from a team as a code owner July 15, 2025 14:34
@Dantemss Dantemss requested review from RoyEJohnson and removed request for a team July 15, 2025 14:34
@RoyEJohnson RoyEJohnson requested a review from jivey July 15, 2025 15:56
Copy link
Contributor

@RoyEJohnson RoyEJohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks reasonable to me, but I'm not familiar with the issues you're addressing. I added Josiah as a reviewer; if you need my approval later, I'll do that.

@jivey
Copy link
Member

jivey commented Jul 15, 2025

@Dantemss The props are a bit arcane but I thought we did have a way to show correct-but-not-selected bubbles if the answer_id didn't match the correct_answer_id:

image

Copy link
Member

@jivey jivey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, but as you mentioned will need some regression testing rendering inside assessments with real data.

@Dantemss
Copy link
Member Author

Dantemss commented Jul 15, 2025

@jivey there was code trying to set styles to invert/not invert the correct answer bubble already, but then the styles in https://github.com/openstax/assessment-components/pull/99/files#diff-a4976d2d79d094466a881e76ee36ad5b4e25305bef76673a0b7f6046099b85adL92 would override everything

@Dantemss Dantemss merged commit 82d64f4 into main Jul 18, 2025
2 checks passed
@Dantemss Dantemss deleted the feat/core-933 branch July 18, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants