Core 899 add option to remove give button from landing page #2727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomWoodward
requested changes
Apr 21, 2025
src/app/layouts/landing/landing.tsx
Outdated
| import './landing.scss'; | ||
|
|
||
| type Props = { | ||
| showGive?: boolean; |
There was a problem hiding this comment.
we're gonna want this to arrive via data.layout[0]?.value.showGive
There was a problem hiding this comment.
I have updated the code & test accordingly.
TomWoodward
approved these changes
Apr 21, 2025
RoyEJohnson
force-pushed
the
core-899-add-option-to-remove-give-button-from-landing-page
branch
from
5639270 to
4d00f2f
Compare
RoyEJohnson
deleted the
core-899-add-option-to-remove-give-button-from-landing-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORE-899
First commit shows changes; second commit applied prettier.