automatically create pedestrian crossing line when joining sidewalk/road #10524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-yle
commented
Nov 2, 2024
| entities[0].tags.footway === 'sidewalk' || | ||
| entities[1].tags.footway === 'sidewalk' || | ||
| entities[0].tags.cycleway === 'sidewalk' || | ||
| entities[1].tags.cycleway === 'sidewalk' |
There was a problem hiding this comment.
| * @param {[string, string][]} edges | ||
| * @param {Tags} connectionTags | ||
| */ | ||
| function actionConnectCrossingWays(loc, edges, connectionTags) { |
There was a problem hiding this comment.
this function is not new, if you click hide whitespace changes, then the github UI understands that this function was simply deindented & moved 20 lines up.
|
@k-yle This looks great. JFYI there are things happening at facebook/Rapid#1583 and facebook/Rapid#1599 which are related to crossings but I did not look into it more, yet. |
|
facebook/Rapid#1583 seems pretty cool, if it were backported to iD, then we should probably auto-create the kerb nodes, otherwise every new crossing will immediately cause a validator warning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7385
When a sidewalk crosses a road, the validator already adds a crossing node, but it does not split the sidewalk line.
This PR makes the validator automatically split the sidewalk and create a
crossingline.after clicking Connect using a crossing:
Most of the code is re-used from the Connect using a bridge/tunnel action. This means the length of the automatically-generated crossing also uses the existing code.